From: Eric Botcazou <ebotcazou@adacore.com>
To: Daniel Cederman <cederman@gaisler.com>
Cc: gcc-patches@gcc.gnu.org, sebastian.huber@embedded-brains.de,
daniel@gaisler.com
Subject: Re: [PATCH v2 3/4] [SPARC] Errata workaround for GRLIB-TN-0010
Date: Mon, 04 Dec 2017 11:06:00 -0000 [thread overview]
Message-ID: <4865132.tcUIKtDO91@polaris> (raw)
In-Reply-To: <20171127095715.5938-4-cederman@gaisler.com>
> @@ -1024,6 +1040,31 @@ sparc_do_work_around_errata (void)
> emit_insn_before (gen_nop (), target);
> }
>
> + /* Insert a NOP between load instruction and atomic
> + instruction. Insert a NOP at branch target if load
> + in delay slot and atomic instruction at branch target. */
> + if (sparc_fix_ut700
> + && NONJUMP_INSN_P (insn)
> + && (set = single_set (insn)) != NULL_RTX
> + && MEM_P (SET_SRC (set))
> + && REG_P (SET_DEST (set)))
Any particular reason to use MEM_P instead of mem_ref here? It looks like
there is also a case for the b2bst workaround (only loads are concerned).
If no, I'll make the changes along with more cosmetic fixes.
--
Eric Botcazou
next prev parent reply other threads:[~2017-12-04 11:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 9:57 [PATCH v2 0/4] [SPARC] Workarounds for UT699, UT700, and GR712RC errata Daniel Cederman
2017-11-27 9:57 ` [PATCH v2 2/4] [SPARC] Errata workaround for GRLIB-TN-0011 Daniel Cederman
2017-11-28 10:03 ` Eric Botcazou
2017-11-27 9:57 ` [PATCH v2 3/4] [SPARC] Errata workaround for GRLIB-TN-0010 Daniel Cederman
2017-11-28 10:04 ` Eric Botcazou
2017-12-04 11:06 ` Eric Botcazou [this message]
2017-12-04 12:25 ` Daniel Cederman
2017-12-04 23:14 ` Eric Botcazou
2017-11-27 10:04 ` [PATCH v2 1/4] [SPARC] Errata workaround for GRLIB-TN-0012 Daniel Cederman
2017-11-28 10:01 ` Eric Botcazou
2017-11-28 12:26 ` Daniel Cederman
2017-11-27 10:04 ` [PATCH v2 4/4] [SPARC] Errata workaround for GRLIB-TN-0013 Daniel Cederman
2017-11-27 16:43 ` Daniel Cederman
2017-11-28 10:08 ` Eric Botcazou
2017-11-28 10:05 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4865132.tcUIKtDO91@polaris \
--to=ebotcazou@adacore.com \
--cc=cederman@gaisler.com \
--cc=daniel@gaisler.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).