From: Jeff Law <law@redhat.com>
To: Bernd Schmidt <bschmidt@redhat.com>,
Joseph Myers <joseph@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: Re: C, C++: Fix PR 69733 (bad location for ignored qualifiers warning)
Date: Thu, 21 Jul 2016 18:39:00 -0000 [thread overview]
Message-ID: <4878b1a4-bdfc-fbd8-95a3-c154aaa5785c@redhat.com> (raw)
In-Reply-To: <ff960637-ff51-2c35-f4b5-5e7899def45f@redhat.com>
On 07/15/2016 07:04 AM, Bernd Schmidt wrote:
> On 06/22/2016 05:37 AM, Jeff Law wrote:
>> It looks like this stalled...
>>
>> Anyway, it's fine for the trunk.
>
> Some of the surrounding code was changed a bit to produce different
> errors for different C standards, so I had to make an adjustment to the
> patch. While I was here, I added cdw_atomic to the list of qualifiers to
> look for, and added a C-specific testcase for that case.
>
> Retested as before. Ok for this version too?
>
>
> Bernd
>
> declspecs-v3.diff
>
>
> c/
> PR c++/69733
> * c-decl.c (smallest_type_quals_location): New static function.
> (grokdeclarator): Try to find the correct location for an ignored
> qualifier.
> cp/
> PR c++/69733
> * decl.c (grokdeclarator): Try to find the correct location for an
> ignored qualifier.
> testsuite/
> PR c++/69733
> * c-c++-common/pr69733.c: New test.
> * gcc.dg/pr69733.c: New test.
> * gcc.target/i386/pr69733.c: New test.
Yes, this version is OK too.
jeff
next prev parent reply other threads:[~2016-07-21 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 13:27 Bernd Schmidt
2016-04-22 14:00 ` Jason Merrill
2016-04-25 20:18 ` Joseph Myers
2016-05-04 15:17 ` Bernd Schmidt
2016-06-02 8:47 ` Bernd Schmidt
2016-06-22 3:37 ` Jeff Law
2016-07-15 13:04 ` Bernd Schmidt
2016-07-21 18:39 ` Jeff Law [this message]
2016-10-07 12:22 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4878b1a4-bdfc-fbd8-95a3-c154aaa5785c@redhat.com \
--to=law@redhat.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).