From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127218 invoked by alias); 21 Jul 2016 18:39:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 127208 invoked by uid 89); 21 Jul 2016 18:39:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Jul 2016 18:39:42 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD090C08E2AA; Thu, 21 Jul 2016 18:39:40 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-70.phx2.redhat.com [10.3.116.70]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6LIddpJ013382; Thu, 21 Jul 2016 14:39:40 -0400 Subject: Re: C, C++: Fix PR 69733 (bad location for ignored qualifiers warning) To: Bernd Schmidt , Joseph Myers References: <571A2697.4050208@t-online.de> <572A128B.4060800@redhat.com> <5493b5ce-7956-9619-0329-06cc30c81f25@redhat.com> Cc: GCC Patches , Jason Merrill From: Jeff Law Message-ID: <4878b1a4-bdfc-fbd8-95a3-c154aaa5785c@redhat.com> Date: Thu, 21 Jul 2016 18:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg01414.txt.bz2 On 07/15/2016 07:04 AM, Bernd Schmidt wrote: > On 06/22/2016 05:37 AM, Jeff Law wrote: >> It looks like this stalled... >> >> Anyway, it's fine for the trunk. > > Some of the surrounding code was changed a bit to produce different > errors for different C standards, so I had to make an adjustment to the > patch. While I was here, I added cdw_atomic to the list of qualifiers to > look for, and added a C-specific testcase for that case. > > Retested as before. Ok for this version too? > > > Bernd > > declspecs-v3.diff > > > c/ > PR c++/69733 > * c-decl.c (smallest_type_quals_location): New static function. > (grokdeclarator): Try to find the correct location for an ignored > qualifier. > cp/ > PR c++/69733 > * decl.c (grokdeclarator): Try to find the correct location for an > ignored qualifier. > testsuite/ > PR c++/69733 > * c-c++-common/pr69733.c: New test. > * gcc.dg/pr69733.c: New test. > * gcc.target/i386/pr69733.c: New test. Yes, this version is OK too. jeff