From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 460A93857344 for ; Mon, 11 Sep 2023 17:20:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 460A93857344 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-68fdcc37827so367095b3a.0 for ; Mon, 11 Sep 2023 10:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1694452833; x=1695057633; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W1vKHwucnNqF6qlBVxnoRzK1ZmYMLsjVMdMFHl/cTbk=; b=EwqGgah24breIPLx9JS0mf7asxV+oyL5nB0sIzaV2EgqGKE0JIQqrvqXv7jdHYPv44 Kot/fakzh4tTjIYlKxMoqflbukvSefsXtfT32jcuSfc8YkTKOwYcwKnA/GoMOdlADs+3 bHmvX6qsOEMJJAa5OeCS3QeboktVbtOI441mJw5WMD4rIKZKIh2qErZnwFJ80fzN2KMt pXHqQyPCEQu9vgwgbKJ5szh3y4IwElA0r84FGoRRuadigmgsaqX6GuoKEtG2RZ6I+rwD QJSd+DKWhUqm0I3ovB9/7QH3irTkCBvMRYa8Ek8q34Ld8sHa/+FlA7BYqy1P/ZbRuEsf /tsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694452833; x=1695057633; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W1vKHwucnNqF6qlBVxnoRzK1ZmYMLsjVMdMFHl/cTbk=; b=KASUPYrXgmrv0vrRw2K/VtZEBvOMYwRYV9vqKDTjjjGkMxPv5V2wJhm0NorX4C9ps3 7KQ/sUMm3KuZk6tHx6UFCyGxgch18D/etzMGyeZo3M+zUdYvu4Ee1v4ifS27UwcKX0B1 pfHexHVSsztYLpNYv418XlSBTAu23KVtpQ0zyAVI4PwzYuIh99WFymuPx6pc2zMzTfL+ XI0/nhWcJe1zsU1Oa7FZ9msLmU7vz7yUFSB7XrPgOLHZUSlLNQlPmSazpQ8FlUaCgk0U Miarg2n+A1S2H0M6tqKYyLohf3TMGRb8FeCPbfBtdnBZn0Nnr2BaZ+1hMBwjmAKFm4XW P3OQ== X-Gm-Message-State: AOJu0YyGxjMvATQdGo8g8Ievf4UtBKUGehN9KRUBIt5nQVEwqSl59Uzx ub2mGSJ2bMuGFDeErtDyQC3M5Q== X-Google-Smtp-Source: AGHT+IEjUuKriSO9jYq5Av8bOGJUEySw/JOHFS28HbwR0vCl30kv/192AadOylYVeQGDsZwgx6mWgw== X-Received: by 2002:a05:6a20:729a:b0:153:4ea6:d128 with SMTP id o26-20020a056a20729a00b001534ea6d128mr272607pzk.13.1694452833084; Mon, 11 Sep 2023 10:20:33 -0700 (PDT) Received: from [10.0.16.63] ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id x7-20020a63b207000000b0055386b1415dsm5766084pge.51.2023.09.11.10.20.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 10:20:32 -0700 (PDT) Message-ID: <487e0b2b-4b4e-4209-b53a-146d0ecb5a59@rivosinc.com> Date: Mon, 11 Sep 2023 10:20:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V Add Types to Un-Typed Thead Instructions: Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org Newsgroups: gmane.comp.gcc.patches References: <20230831173637.583424-1-ewlu@rivosinc.com> <7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com> From: Edwin Lu In-Reply-To: <7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/10/2023 8:37 AM, Jeff Law via Gcc-patches wrote: > > > On 8/31/23 11:36, Edwin Lu wrote: >> Related Discussion: >> https://inbox.sourceware.org/gcc-patches/12fb5088-3f28-0a69-de1e-f387371a5eb2@gmail.com/ >> >> This patch updates the THEAD instructions to ensure that no insn is left >> without a type attribute. >> >> Tested for regressions using rv32/64 multilib for linux/newlib. >> >> gcc/Changelog: >> >>     * config/riscv/thead.md: Update types > OK.  THe first could arguably be "multi", but both instructions it > generates appear to be move/conversions, so "fmove" is reasonable as well. > > Ok for the trunk.  And I think that's should allow us to turn on the > assertion, right? > > jeff > I just did one final check, there's one insn in autovec-opt.md that was added (line 635) but otherwise I think that should be it. I've typed it "vector" for now and am currently running a test to make sure nothing breaks. Would you like me to send another patch for it? Edwin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id BB1423856DDF for ; Mon, 11 Sep 2023 17:20:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB1423856DDF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qfkaU-0000iV-Ut for gcc-patches@gcc.gnu.org; Mon, 11 Sep 2023 19:20:38 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Edwin Lu Subject: Re: [PATCH] RISC-V Add Types to Un-Typed Thead Instructions: Date: Mon, 11 Sep 2023 10:20:30 -0700 Message-ID: <487e0b2b-4b4e-4209-b53a-146d0ecb5a59@rivosinc.com> References: <20230831173637.583424-1-ewlu@rivosinc.com> <7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: <7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230911172030.BkgHmnv8VvIioQRTGq_Mye3Ia1podKNCrOnZYGsVW6U@z> On 9/10/2023 8:37 AM, Jeff Law via Gcc-patches wrote: > > > On 8/31/23 11:36, Edwin Lu wrote: >> Related Discussion: >> https://inbox.sourceware.org/gcc-patches/12fb5088-3f28-0a69-de1e-f387371a5eb2@gmail.com/ >> >> This patch updates the THEAD instructions to ensure that no insn is left >> without a type attribute. >> >> Tested for regressions using rv32/64 multilib for linux/newlib. >> >> gcc/Changelog: >> >>     * config/riscv/thead.md: Update types > OK.  THe first could arguably be "multi", but both instructions it > generates appear to be move/conversions, so "fmove" is reasonable as well. > > Ok for the trunk.  And I think that's should allow us to turn on the > assertion, right? > > jeff > I just did one final check, there's one insn in autovec-opt.md that was added (line 635) but otherwise I think that should be it. I've typed it "vector" for now and am currently running a test to make sure nothing breaks. Would you like me to send another patch for it? Edwin