Re: [PATCH v1 1/1] gcc: config: microblaze: fix cpu version check

["Frager, Neal" <neal.frager@amd.com>]

> Le 23 oct. 2023 à 18:40, Michael Eager <eager@eagercon.com> a écrit :
> 
> On 10/22/23 22:48, Neal Frager wrote:
>> There is a microblaze cpu version 10.0 included in versal. If the
>> minor version is only a single digit, then the version comparison
>> will fail as version 10.0 will appear as 100 compared to version
>> 6.00 or 8.30 which will calculate to values 600 and 830.
>> The issue can be seen when using the '-mcpu=10.0' option.
>> With this fix, versions with a single digit minor number such as
>> 10.0 will be calculated as greater than versions with a smaller
>> major version number, but with two minor version digits.
>> By applying this fix, several incorrect warning messages will no
>> longer be printed when building the versal plm application, such
>> as the warning message below:
>> warning: '-mxl-multiply-high' can be used only with '-mcpu=v6.00.a' or greater
>> Signed-off-by: Neal Frager <neal.frager@amd.com>
>> ---
>>  gcc/config/microblaze/microblaze.cc | 164 +++++++++++++---------------
>>  1 file changed, 76 insertions(+), 88 deletions(-)
> 
> Please add a test case.
> 
> --
> Michael Eager

Hi Michael,

Would you mind helping me understand how to make a gcc test case for this patch?

This patch does not change the resulting binaries of a microblaze gcc build.  The output will be the same with our without the patch, so I do not having anything in the binary itself to verify.

All that happens is false warning messages will not be printed when building with ‘-mcpu=10.0’.  Is there a way to test for warning messages?

In any case, please do not commit v1 of this patch.  I am going to work on making a v2 based on Mark’s feedback.

Thanks for your help!

Best regards,
Neal Frager
AMD