From: Andrey Belevantsev <abel@ispras.ru>
To: Ian Lance Taylor <iant@google.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Jim Wilson <wilson@tuliptree.org>,
Vladimir Makarov <vmakarov@redhat.com>
Subject: Re: Selective scheduling pass - middle end changes [1/1]
Date: Fri, 22 Aug 2008 15:55:00 -0000 [thread overview]
Message-ID: <48AEDB97.3040900@ispras.ru> (raw)
In-Reply-To: <m3lk1ceqat.fsf@google.com>
[-- Attachment #1: Type: text/plain, Size: 3175 bytes --]
Hello Ian,
Here is the updated patch that has all your comments addressed and the
RTL hooks removed. As I wrote in a separate email
(http://gcc.gnu.org/ml/gcc-patches/2008-08/msg01052.html), I apologize
for making too much noise about the RTL hooks problem -- with Zdenek's
suggestion, it is actually solved very easily. This patch has the only
addition compared to the original patch in final.c which fixes a FAIL on
ia64 with the dump-addr.c test case. When the dump file is used,
dominator information does not get freed in compute_alignment, thus
resulting in ICE in verify_dominators later in the selective scheduling.
The addition itself was committed to the branch at
http://gcc.gnu.org/ml/gcc-patches/2008-08/msg01633.html.
Thanks again for your review,
Andrey
2008-08-22 Andrey Belevantsev <abel@ispras.ru>
Dmitry Melnik <dm@ispras.ru>
Dmitry Zhurikhin <zhur@ispras.ru>
Alexander Monakov <amonakov@ispras.ru>
Maxim Kuvyrkov <maxim@codesourcery.com>
* cfghooks.h (get_cfg_hooks, set_cfg_hooks): New prototypes.
* cfghooks.c (get_cfg_hooks, set_cfg_hooks): New functions.
(make_forwarder_block): Update loop latch if we have redirected
the loop latch edge.
* cfgloop.c (get_loop_body_in_custom_order): New function.
* cfgloop.h (LOOPS_HAVE_FALLTHRU_PREHEADERS): New enum field.
(CP_FALLTHRU_PREHEADERS): Likewise.
(get_loop_body_in_custom_order): Declare.
* cfgloopmanip.c (has_preds_from_loop): New.
(create_preheader): Honor CP_FALLTHRU_PREHEADERS.
Assert that the preheader edge will be fall thru when it is set.
* cse.c (hash_rtx_cb): New.
(hash_rtx): Use it.
* final.c (compute_alignments): Export. Free dominance info after
loop_optimizer_finalize.
* genattr.c (main): Output maximal_insn_latency prototype.
* genautomata.c (output_default_latencies): New. Factor its code from ...
(output_internal_insn_latency_func): ... here.
(output_internal_maximal_insn_latency_func): New.
(output_maximal_insn_latency_func): New.
* hard-reg-set.h (UHOST_BITS_PER_WIDE_INT): Define unconditionally.
(struct hard_reg_set_iterator): New.
(hard_reg_set_iter_init, hard_reg_set_iter_set,
hard_reg_set_iter_next): New functions.
(EXECUTE_IF_SET_IN_HARD_REG_SET): New macro.
* lists.c (remove_free_INSN_LIST_node,
remove_free_EXPR_LIST_node): New functions.
* loop-init.c (loop_optimizer_init): When LOOPS_HAVE_FALLTHRU_PREHEADERS,
set CP_FALLTHRU_PREHEADERS when calling create_preheaders.
(loop_optimizer_finalize): Do not verify flow info after reload.
* recog.c (validate_replace_rtx_1): New parameter simplify.
Default it to true. Update all uses. Factor out simplifying
code to ...
(simplify_while_replacing): ... this new function.
(validate_replace_rtx_part,
validate_replace_rtx_part_nosimplify): New.
* recog.h (validate_replace_rtx_part,
validate_replace_rtx_part_nosimplify): Declare.
* rtl.c (rtx_equal_p_cb): New.
(rtx_equal_p): Use it.
* rtl.h (rtx_equal_p_cb, hash_rtx_cb): Declare.
(remove_free_INSN_LIST_NODE, remove_free_EXPR_LIST_node,
debug_bb_n_slim, debug_bb_slim, print_rtl_slim): Likewise.
* vecprim.h: Add a vector type for unsigned int.
[-- Attachment #2: sel-sched-middle.diff.gz --]
[-- Type: application/gzip, Size: 26761 bytes --]
next prev parent reply other threads:[~2008-08-22 15:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 14:24 [RFC] Selective scheduling pass Andrey Belevantsev
2008-06-03 14:26 ` Selective scheduling pass - middle end changes [1/1] Andrey Belevantsev
2008-06-11 1:04 ` Ian Lance Taylor
2008-06-11 13:40 ` Andrey Belevantsev
2008-06-11 14:30 ` Ian Lance Taylor
2008-06-27 13:10 ` Andrey Belevantsev
2008-06-30 16:16 ` Ian Lance Taylor
2008-07-08 14:54 ` Andrey Belevantsev
2008-07-08 15:29 ` Ian Lance Taylor
2008-08-22 15:55 ` Andrey Belevantsev [this message]
2008-06-03 14:27 ` Selective scheduling pass - scheduler changes [2/3] Andrey Belevantsev
2008-06-03 22:03 ` Vladimir Makarov
2008-08-22 15:52 ` Andrey Belevantsev
2008-06-03 14:28 ` Selective scheduling pass - target changes (ia64 & rs6000) [3/3] Andrey Belevantsev
2008-08-22 16:04 ` Andrey Belevantsev
2008-08-29 13:41 ` [Ping] [GWP/ia64/rs6000 maintainer needed] " Andrey Belevantsev
2008-08-29 15:01 ` Mark Mitchell
2008-09-25 22:39 ` sje
2008-09-26 14:57 ` Andrey Belevantsev
2008-10-03 22:22 ` Steve Ellcey
2008-10-06 17:26 ` Andrey Belevantsev
2008-06-03 22:03 ` [RFC] Selective scheduling pass Vladimir Makarov
2008-06-04 16:55 ` Mark Mitchell
2008-06-04 20:50 ` Andrey Belevantsev
2008-06-05 3:45 ` Seongbae Park (박성배, 朴成培)
2008-06-05 13:49 ` Andrey Belevantsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AEDB97.3040900@ispras.ru \
--to=abel@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
--cc=vmakarov@redhat.com \
--cc=wilson@tuliptree.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).