Re: [patch] libffi, fix powerpc-unknown-freebsd

[Andreas Tobler <andreast-list@fgznet.ch>]

David Edelsohn wrote:
> On Thu, Aug 21, 2008 at 5:53 PM, Andreas Tobler <andreast-list@fgznet.ch> wrote:
>> Instead of playing with FFI_SYSV_TYPE_SMALL_STRUCT for bit shifts I
>> introduced two new flags which tell us if we need r3 or r3 and r4 for
>> structs passing.
>>
>> The issue is this, I need to tell the ppc_closure.S exactly which type I
>> expect when returning. And unfortunatley the implementation needs a
>> distinction for every type and size. Type 1 to 15 are already used, so I can
>> start with using type 16 and up.
> 
> I mainly want a comment that two bits are used, especially in
> ffitarget.h.  Thanks for the additional explanation.

Thanks for review.

I have an understanding issue here, what bits are you referring to? The 
FLAG_SYSV_SMST_R4 and FLAG_SYSV_SMST_R3 from ffi.c?
Or the situation that I use FFI_SYSV_TYPE_SMALL_STRUCT and the two flags?
If the former, then my impression is that they don't need to be 
mentioned in ffitarget.h, otherwise we'd have to describe every flag 
used in ffi.c in ffitarget.h as well.
If the latter, I can put a note into ffitarget.h mentioning that we need 
additional separation in ffi.c to clearly distinguish what we return.

Else, if I completely misunderstood you, would you mind explaining me 
what you would like to read?

Thanks in advance,
Andreas