David Edelsohn wrote:
> On Sun, Aug 24, 2008 at 4:08 PM, Andreas Tobler <andreast-list@fgznet.ch> wrote:
> 
>> I have an understanding issue here, what bits are you referring to? The
>> FLAG_SYSV_SMST_R4 and FLAG_SYSV_SMST_R3 from ffi.c?
>> Or the situation that I use FFI_SYSV_TYPE_SMALL_STRUCT and the two flags?
>> If the former, then my impression is that they don't need to be mentioned in
>> ffitarget.h, otherwise we'd have to describe every flag used in ffi.c in
>> ffitarget.h as well.
>> If the latter, I can put a note into ffitarget.h mentioning that we need
>> additional separation in ffi.c to clearly distinguish what we return.
> 
> FLAG_SYSV_TYPE_SMALL_STRUCT uses two bits in flags, if I understand
> the code correctly.  I think it would be helpful to note that in
> ffitarget.h

I will commit the attached to trunk in a few minutes. For 4.3 I'll wait 
until 4.3.3 opens, ok?

Thank you for review.

Regards,
Andreas


2008-08-25  Andreas Tobler  <a.tobler@schweiz.org>

	* src/powerpc/ffitarget.h (ffi_abi): Add FFI_LINUX and
	FFI_LINUX_SOFT_FLOAT to the POWERPC_FREEBSD enum.
	Add note about flag bits used for FFI_SYSV_TYPE_SMALL_STRUCT.
	Adjust copyright notice.
	* src/powerpc/ffi.c: Add two new flags to indicate if we have one
	register or two register to use for FFI_SYSV structs.
	(ffi_prep_cif_machdep): Pass the right register flag introduced above.
	(ffi_closure_helper_SYSV): Fix the return type for
	FFI_SYSV_TYPE_SMALL_STRUCT. Comment.
	Adjust copyright notice.