* [PING][PATCH] PR29474: Don't canonicalize commutative operands during reload
@ 2008-08-28 9:16 Maxim Kuvyrkov
2008-11-20 12:11 ` [PING^2][PATCH] " Maxim Kuvyrkov
0 siblings, 1 reply; 4+ messages in thread
From: Maxim Kuvyrkov @ 2008-08-28 9:16 UTC (permalink / raw)
To: gcc-patches; +Cc: Roman Zippel, Andreas Schwab
Hello,
I'd like to ping patch in
http://gcc.gnu.org/ml/gcc-patches/2007-09/msg00817.html.
While testing trunk and 4.3 branch for ColdFire, I noticed several
failures in gcc.c-torture testsuite, which the above patch fixes.
The patch was tested on m68k-linux-gnu and m68k-elf (both for coldfire)
with no new regressions.
Thanks,
Maxim Kuvyrkov
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PING^2][PATCH] PR29474: Don't canonicalize commutative operands during reload
2008-08-28 9:16 [PING][PATCH] PR29474: Don't canonicalize commutative operands during reload Maxim Kuvyrkov
@ 2008-11-20 12:11 ` Maxim Kuvyrkov
2008-11-21 22:06 ` Andreas Schwab
2008-11-25 20:59 ` Jeff Law
0 siblings, 2 replies; 4+ messages in thread
From: Maxim Kuvyrkov @ 2008-11-20 12:11 UTC (permalink / raw)
To: gcc-patches; +Cc: Roman Zippel, Andreas Schwab, Bernd Schmidt
Maxim Kuvyrkov wrote:
> Hello,
>
> I'd like to ping patch in
> http://gcc.gnu.org/ml/gcc-patches/2007-09/msg00817.html.
>
> While testing trunk and 4.3 branch for ColdFire, I noticed several
> failures in gcc.c-torture testsuite, which the above patch fixes.
>
> The patch was tested on m68k-linux-gnu and m68k-elf (both for coldfire)
> with no new regressions.
Ping.
Without this patch current trunk ICEs in reload when compiling
gcc.c-torture/execute/20060420-1.c for m68k/ColdFire. The fix is safe
(as it just reduces optimization space) and it does not affect
benchmarks (EEMBC and CSiBE were tested).
Is there any chance of committing this before 4.4 branches or should I
ping again when stage1 has started.
Thanks,
MaximK
CodeSourcery
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PING^2][PATCH] PR29474: Don't canonicalize commutative operands during reload
2008-11-20 12:11 ` [PING^2][PATCH] " Maxim Kuvyrkov
@ 2008-11-21 22:06 ` Andreas Schwab
2008-11-25 20:59 ` Jeff Law
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Schwab @ 2008-11-21 22:06 UTC (permalink / raw)
To: Maxim Kuvyrkov; +Cc: gcc-patches, Roman Zippel, Bernd Schmidt
Maxim Kuvyrkov <maxim@codesourcery.com> writes:
> Without this patch current trunk ICEs in reload when compiling
> gcc.c-torture/execute/20060420-1.c for m68k/ColdFire.
This is PR37053, btw.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PING^2][PATCH] PR29474: Don't canonicalize commutative operands during reload
2008-11-20 12:11 ` [PING^2][PATCH] " Maxim Kuvyrkov
2008-11-21 22:06 ` Andreas Schwab
@ 2008-11-25 20:59 ` Jeff Law
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2008-11-25 20:59 UTC (permalink / raw)
To: Maxim Kuvyrkov; +Cc: gcc-patches, Roman Zippel, Andreas Schwab, Bernd Schmidt
Maxim Kuvyrkov wrote:
> Maxim Kuvyrkov wrote:
>> Hello,
>>
>> I'd like to ping patch in
>> http://gcc.gnu.org/ml/gcc-patches/2007-09/msg00817.html.
>>
>> While testing trunk and 4.3 branch for ColdFire, I noticed several
>> failures in gcc.c-torture testsuite, which the above patch fixes.
>>
>> The patch was tested on m68k-linux-gnu and m68k-elf (both for
>> coldfire) with no new regressions.
>
> Ping.
>
> Without this patch current trunk ICEs in reload when compiling
> gcc.c-torture/execute/20060420-1.c for m68k/ColdFire. The fix is safe
> (as it just reduces optimization space) and it does not affect
> benchmarks (EEMBC and CSiBE were tested).
>
> Is there any chance of committing this before 4.4 branches or should I
> ping again when stage1 has started.
>
Given it's a bugfix I think it's appropriate to pursue at this stage.
The biggest concern is that this code (reload) can sometimes be rather
fragile.
I think we want to avoid all simplifications by validate_replace_rtx
during reload. I think the easiest way to accomplish this would be to
make a change from
validate_replace_rtx_1 (&PATTERN (insn), from, to, insn, true);
to
validate_replace_rtx_1 (&PATTERN (insn), from, to, insn,
(reload_in_progress ? false : true));
Within validate_replace_rtx. This would need some widespread testing
across multiple targets, but I do think it's the right way to approach
the problem (or as an alternative, add validate_replace_rtx_nosimplify
and use that within reload1.c).
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-25 19:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-28 9:16 [PING][PATCH] PR29474: Don't canonicalize commutative operands during reload Maxim Kuvyrkov
2008-11-20 12:11 ` [PING^2][PATCH] " Maxim Kuvyrkov
2008-11-21 22:06 ` Andreas Schwab
2008-11-25 20:59 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).