* PING: [df] Always mark the stack pointer as defined on entry.
@ 2008-09-03 19:13 Richard Sandiford
2008-09-03 19:23 ` H.J. Lu
2008-09-03 22:04 ` Richard Henderson
0 siblings, 2 replies; 5+ messages in thread
From: Richard Sandiford @ 2008-09-03 19:13 UTC (permalink / raw)
To: gcc-patches
http://gcc.gnu.org/ml/gcc-patches/2008-08/msg02236.html
Tell DF that the incoming stack pointer is always important.
The current code assumes that the initial value of the stack
pointer isn't relevant once the prologue has been generated.
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PING: [df] Always mark the stack pointer as defined on entry.
2008-09-03 19:23 ` H.J. Lu
@ 2008-09-03 19:23 ` Richard Sandiford
2008-09-05 7:49 ` Ye, Joey
0 siblings, 1 reply; 5+ messages in thread
From: Richard Sandiford @ 2008-09-03 19:23 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches
"H.J. Lu" <hjl.tools@gmail.com> writes:
> On Wed, Sep 3, 2008 at 12:06 PM, Richard Sandiford
> <rdsandiford@googlemail.com> wrote:
>> http://gcc.gnu.org/ml/gcc-patches/2008-08/msg02236.html
>> Tell DF that the incoming stack pointer is always important.
>> The current code assumes that the initial value of the stack
>> pointer isn't relevant once the prologue has been generated.
>>
>
> Do you have any testcases to show how your change affects
> generated codes?
The testcase is in the R10K speculation patch:
http://gcc.gnu.org/ml/gcc-patches/2008-09/msg00041.html
(Sorry, although I referred vaguely to that in the original submission,
I should have mentioned it by name now that the R10K patch has been
posted.)
> How will your change interact with dynamic stack alignment?
I don't believe it will. This patch only affects the behaviour
_after_ prologue and epilogue generation. My understanding is
that all dsa-specific stuff will have been done by then.
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PING: [df] Always mark the stack pointer as defined on entry.
2008-09-03 19:13 PING: [df] Always mark the stack pointer as defined on entry Richard Sandiford
@ 2008-09-03 19:23 ` H.J. Lu
2008-09-03 19:23 ` Richard Sandiford
2008-09-03 22:04 ` Richard Henderson
1 sibling, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2008-09-03 19:23 UTC (permalink / raw)
To: gcc-patches, rdsandiford
On Wed, Sep 3, 2008 at 12:06 PM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:
> http://gcc.gnu.org/ml/gcc-patches/2008-08/msg02236.html
> Tell DF that the incoming stack pointer is always important.
> The current code assumes that the initial value of the stack
> pointer isn't relevant once the prologue has been generated.
>
Do you have any testcases to show how your change affects
generated codes? How will your change interact with dynamic
stack alignment?
--
H.J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PING: [df] Always mark the stack pointer as defined on entry.
2008-09-03 19:13 PING: [df] Always mark the stack pointer as defined on entry Richard Sandiford
2008-09-03 19:23 ` H.J. Lu
@ 2008-09-03 22:04 ` Richard Henderson
1 sibling, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2008-09-03 22:04 UTC (permalink / raw)
To: gcc-patches, rdsandiford
Richard Sandiford wrote:
> http://gcc.gnu.org/ml/gcc-patches/2008-08/msg02236.html
Ok.
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: PING: [df] Always mark the stack pointer as defined on entry.
2008-09-03 19:23 ` Richard Sandiford
@ 2008-09-05 7:49 ` Ye, Joey
0 siblings, 0 replies; 5+ messages in thread
From: Ye, Joey @ 2008-09-05 7:49 UTC (permalink / raw)
To: Richard Sandiford, H.J. Lu; +Cc: gcc-patches
Richard Wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>> How will your change interact with dynamic stack alignment?
>
> I don't believe it will. This patch only affects the behaviour
> _after_ prologue and epilogue generation. My understanding is
> that all dsa-specific stuff will have been done by then.
Looks OK for stack alignment.
Thanks - Joey
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-09-05 7:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-03 19:13 PING: [df] Always mark the stack pointer as defined on entry Richard Sandiford
2008-09-03 19:23 ` H.J. Lu
2008-09-03 19:23 ` Richard Sandiford
2008-09-05 7:49 ` Ye, Joey
2008-09-03 22:04 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).