From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8767 invoked by alias); 4 Sep 2008 15:36:06 -0000 Received: (qmail 8759 invoked by uid 22791); 4 Sep 2008 15:36:05 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Sep 2008 15:35:09 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m84FZ7Wk017714; Thu, 4 Sep 2008 11:35:07 -0400 Received: from pobox-3.corp.redhat.com (pobox-3.corp.redhat.com [10.11.255.67]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m84FZ6qX001042; Thu, 4 Sep 2008 11:35:06 -0400 Received: from toll.yyz.redhat.com (toll.yyz.redhat.com [10.15.16.165]) by pobox-3.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m84FZ53D007167; Thu, 4 Sep 2008 11:35:05 -0400 Message-ID: <48C00029.1080304@redhat.com> Date: Thu, 04 Sep 2008 15:39:00 -0000 From: Vladimir Makarov User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: "H.J. Lu" CC: Jeff Law , gcc-patches , Kenneth Zadeck Subject: Re: RFA: patch to solve spec2006 degradation reported in 37243 References: <48B999DF.7080500@redhat.com> <48BEEF14.4050206@redhat.com> <48BEF1FC.6070506@redhat.com> <20080904045836.GA25663@lucon.org> In-Reply-To: <20080904045836.GA25663@lucon.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-09/txt/msg00359.txt.bz2 H.J. Lu wrote: > On Wed, Sep 03, 2008 at 04:22:20PM -0400, Vladimir Makarov wrote: > >> Jeff Law wrote: >> >>> Vladimir Makarov wrote: >>> >>>> The following patch solves SPEC2006 degradation reported in PR37243. >>>> The analysis of the problem can be found in >>>> >>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37243 >>>> >>>> The patch was successfully bootstrapped and tested on x86_64. >>>> >>>> 2008-08-30 Vladimir Makarov >>>> >>>> PR rtl-opt/37243 >>>> >>>> * ira-int.h (ira_loop_tree_node): Rename mentioned_allocnos to >>>> all_allocnos. >>>> >>>> * ira-color.c (print_loop_title): Use all_allocnos. >>>> (color_pass): Ditto. Don't add border_allocnos. Check that >>>> subloop allocno in the correspdoning bitmap all_allocnos. >>>> >>>> * ira-emit.c (change_loop): Use all_allocnos. >>>> >>>> * ira-build.c (create_loop_tree_nodes, finish_loop_tree_node): >>>> Ditto. >>>> (ira_create_allocno): Set up all_allocnos bit for the created >>>> allocno. >>>> (create_cap_allocno): Remove setting mentioned_allocnos. >>>> (create_insn_allocnos): Ditto. >>>> (remove_unnecessary_allocnos): Use all_allocnos. >>>> (check_allocno_creation): Check that allocnos are in the >>>> corresponding bitmap all_allocnos. >>>> >>>> >>> OK. Please install if you haven't done so already. >>> >> Thanks. Done. >> > > Here is the testcase for this bug. It failed at -O2 before the > fix was checked in. OK for trunk? > > > 2008-09-03 H.J. Lu > > PR rtl-optimization/37243 > * gfortran.dg/pr37243.f: New. > > > Thanks, H.J. It looks ok to me to commit to the trunk. That was a really good test for IRA. I should have added it the first time.