public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Simon Baldwin <simonb@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][RFC] -Wno-... option to suppress builtin macro redefined  warnings
Date: Tue, 16 Sep 2008 16:11:00 -0000	[thread overview]
Message-ID: <48CFC698.5050308@google.com> (raw)
In-Reply-To: <m3wshgvost.fsf@fleche.redhat.com>

Tom Tromey wrote:
>>>>>> "Simon" == Simon Baldwin <simonb@google.com> writes:
>>>>>>             
>
> Simon> ...so, attached below is a re-draft of this patch to bifurcate
> Simon> built-in macros so that only TIMESTAMP, TIME, DATE, FILE, and
> Simon> FILE_BASE are affected by -Wno-builtin-macro-redefined, and other
> Simon> built-in macros always warn if redefined.
>
> Simon> Please take another look when time permits, to see if you like this
> Simon> version better than the first.  And thanks again for the feedback.
>
> I can only approve the libcpp parts -- those are ok.

Thanks for the nod, much appreciated.

Any ideas of a victim to approve the tiny c.opt and c-opts.c parts to 
control this?  Volunteers haven't exactly been leaping forwards.  Thanks.

-- 
Google UK Limited | Registered Office: Belgrave House, 76 Buckingham
Palace Road, London SW1W 9TQ | Registered in England Number: 3977902

  reply	other threads:[~2008-09-16 14:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 15:12 Simon Baldwin
2008-07-30 15:27 ` Joseph S. Myers
2008-08-08 16:01 ` Tom Tromey
2008-08-08 16:09   ` Manuel López-Ibáñez
2008-08-08 16:21     ` Tom Tromey
2008-08-08 16:23   ` Simon Baldwin
2008-08-15 17:28     ` Simon Baldwin
     [not found]       ` <48AEE7A7.9000509@google.com>
2008-08-22 17:17         ` Tom Tromey
2008-08-26 18:38           ` Simon Baldwin
2008-09-02 11:29             ` Simon Baldwin
2008-09-13  7:42             ` Tom Tromey
2008-09-16 16:11               ` Simon Baldwin [this message]
2008-09-17 14:19               ` Ian Lance Taylor
2008-09-18 16:04                 ` Simon Baldwin
2008-09-17 14:24             ` Ian Lance Taylor
2008-08-22 16:53 Simon Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48CFC698.5050308@google.com \
    --to=simonb@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).