public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: sje@cup.hp.com
Cc: Peter Bergner <bergner@vnet.ibm.com>,
	gcc-patches@gcc.gnu.org,         paolo.carlini@oracle.com
Subject: Re: Patch to fix gcc.c-torture/compile/20010102-1.c on IA64 HP-UX
Date: Tue, 16 Sep 2008 21:48:00 -0000	[thread overview]
Message-ID: <48D0248E.5030505@redhat.com> (raw)
In-Reply-To: <1221596846.17787.28.camel@hpsje.cup.hp.com>


Steve Ellcey wrote:
> On Tue, 2008-09-16 at 14:15 -0600, Jeff Law wrote:
>
>   
>> But this shouldn't be necessary.  REG_POINTER is set within the RTX for 
>> the original pseudo and alter_reg (via changing REGNO) preserves the 
>> setting for use post-reload, even though we're looking at a hard register.
>>
>> My recommendation for Steve is the same.  First ensure that REG_POINTER 
>> is set on the appropriate REG within the insn when the insn is created, 
>> then go forward and pinpoint where it disappears as the disappearance is 
>> a bug.
>> Jeff
>>     
>
> Well, it disappears during the rtx register renaming phase and
> I thought I was fixing it by preserving it during register renaming.
> This is where it disappears.   If I add -fno-rename-registers the
> problem goes away.
>   
I went back and found the original message (luckily this is a short 
thread :-)


I think the real problem here is definitely regrename.   We do have to 
be careful about setting REG_POINTER on a hard register, but I think 
we're OK in do_replace as we're always generating a new RTX in that case.

The other two are less clear.  If we choose to only fix do_replace, then 
we might want an indicator in the debugging dumps for the other two 
(find_oldest_value_reg, copyprop_hardreg_forward_1)  when we lose a 
REG_POINTER flag.  It might help diagnose future instances of this problem.

Jeff


  parent reply	other threads:[~2008-09-16 21:31 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-16 18:21 Steve Ellcey
2008-09-16 19:00 ` Peter Bergner
2008-09-16 19:20   ` Steve Ellcey
2008-09-16 19:40     ` Peter Bergner
2008-09-16 21:55       ` Jakub Jelinek
2008-09-17  1:22         ` Peter Bergner
2008-09-16 19:44     ` Jeff Law
2008-09-16 20:20       ` Peter Bergner
2008-09-16 20:49         ` Jeff Law
2008-09-16 20:49           ` Steve Ellcey
2008-09-16 21:31             ` Jeff Law
2008-09-16 21:40               ` Steve Ellcey
2008-09-17  1:54                 ` Peter Bergner
2008-09-17 17:31                   ` Steve Ellcey
2008-09-18 16:03                   ` Steve Ellcey
2008-09-18 20:38                     ` Peter Bergner
2008-09-16 21:48             ` Jeff Law [this message]
2008-09-16 22:00               ` Steve Ellcey
2008-09-18 20:59                 ` Richard Henderson
2008-09-19 18:56                   ` Steve Ellcey
2008-09-23 20:55                     ` Jeff Law
2008-09-23 21:08                       ` Steve Ellcey
2008-10-03 19:35                         ` Luis Machado
2008-10-04  0:47                           ` Jeff Law
2008-10-04  1:09                             ` Andrew Pinski
2008-10-16 21:46                               ` Luis Machado
2008-10-16 22:02                                 ` Jeff Law
2008-10-30 22:27                                   ` Luis Machado
2008-10-31  2:23                                     ` Steve Ellcey
2008-10-31  2:17                                       ` Peter Bergner
2008-10-31  2:03                                         ` Jeff Law
2008-10-31  1:50                                           ` Steve Ellcey
2008-11-06 18:00                                             ` Jeff Law
2008-10-31 10:53                                           ` Jakub Jelinek
2008-10-31 20:29                                           ` Peter Bergner
2008-10-31 20:50                                             ` Luis Machado
2008-10-31 21:27                                             ` Jakub Jelinek
2008-11-06 18:25                                     ` Jeff Law
2008-11-06 20:43 David Edelsohn
2008-11-06 22:05 ` Jeff Law
2008-11-06 23:29   ` David Edelsohn
2008-11-06 23:48     ` Jeff Law
2008-11-07 18:58       ` Luis Machado
2008-11-27 14:34       ` Luis Machado
2008-11-27 15:46         ` Richard Guenther
2008-11-27 20:32         ` Jeff Law
2008-11-27 21:07           ` Luis Machado
2008-11-27 23:24             ` Jeff Law
2009-05-26 16:50               ` Luis Machado
2009-06-01  3:55                 ` Ian Lance Taylor
2009-06-01 15:21                   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D0248E.5030505@redhat.com \
    --to=law@redhat.com \
    --cc=bergner@vnet.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paolo.carlini@oracle.com \
    --cc=sje@cup.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).