Re: [PATCH][RFC] -Wno-... option to suppress builtin macro redefined warnings

[Simon Baldwin <simonb@google.com>]

> Ian Lance Taylor wrote:
>> > +@item -Wno-builtin-macro-redefined
>> > +@opindex Wno-builtin-macro-redefined
>> > +@opindex Wbuiltin-macro-redefined
>> > +Do not warn if a certain built-in macros are redefined.  This suppresses
>> > +warnings for redefinition of @code{__TIMESTAMP__}, @code{__TIME__},
>> > +@code{__DATE__}, @code{__FILE__}, and @code{__BASE_FILE__}.
>>     
>
> s/if a certain/if certain/
>   

Updated, thanks.

> Tom Tromey <tromey@redhat.com> writes:
>
>   
>>>>>>> "Simon" == Simon Baldwin <simonb@google.com> writes:
>>>>>>>               
>> Simon> ...so, attached below is a re-draft of this patch to bifurcate
>> Simon> built-in macros so that only TIMESTAMP, TIME, DATE, FILE, and
>> Simon> FILE_BASE are affected by -Wno-builtin-macro-redefined, and other
>> Simon> built-in macros always warn if redefined.
>>
>> Simon> Please take another look when time permits, to see if you like this
>> Simon> version better than the first.  And thanks again for the feedback.
>>
>> I can only approve the libcpp parts -- those are ok.
>>     
>
> The rest of the patch is OK.

Thanks.  Committed revision 140461.

-- 
Google UK Limited | Registered Office: Belgrave House, 76 Buckingham
Palace Road, London SW1W 9TQ | Registered in England Number: 3977902