From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32408 invoked by alias); 12 Oct 2008 21:29:42 -0000 Received: (qmail 32400 invoked by uid 22791); 12 Oct 2008 21:29:42 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 12 Oct 2008 21:29:06 +0000 Received: (qmail 28318 invoked from network); 12 Oct 2008 21:29:04 -0000 Received: from unknown (HELO ?192.168.0.3?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 12 Oct 2008 21:29:04 -0000 Message-ID: <48F26C19.6080803@codesourcery.com> Date: Mon, 13 Oct 2008 03:24:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Simon Martin CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix PR c++/37647: ICE with invalid use of constructor References: <48E59333.8020004@users.sourceforge.net> In-Reply-To: <48E59333.8020004@users.sourceforge.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-10/txt/msg00538.txt.bz2 Simon Martin wrote: > The problem is that DECL_CONSTRUCTOR is set for "void A();", which > implies that we call 'grok_ctor_properties' itself calling 'copy_fn_p', > that asserts that the passed declaration "has" DECL_FUNCTION_MEMBER_P, > which is obviously not the case here. Is there any way that we can avoid even getting the idea that this is an sfk_constructor? Your patch seems like it's a bit later than we'd like; we're concluding that the function is sfk_constructor and then backing out when we notice that ctype is NULL. Can we just avoid concluding this is a constructor at all? Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713