From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp114.ord1d.emailsrvr.com (smtp114.ord1d.emailsrvr.com [184.106.54.114]) by sourceware.org (Postfix) with ESMTPS id DACC63858C2D for ; Tue, 26 Jul 2022 01:38:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DACC63858C2D X-Auth-ID: tom@honermann.net Received: by smtp15.relay.ord1d.emailsrvr.com (Authenticated sender: tom-AT-honermann.net) with ESMTPSA id 5B157601AF; Mon, 25 Jul 2022 21:38:13 -0400 (EDT) Message-ID: <48b1fb5b-21b9-b14f-1c95-9346083ab24f@honermann.net> Date: Mon, 25 Jul 2022 21:38:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 3/3] c++/106426: Treat u8 character literals as unsigned in char8_t modes. Content-Language: en-US To: Andrew Pinski Cc: GCC Patches References: <20220725175948.1424695-1-tom@honermann.net> <20220725175948.1424695-4-tom@honermann.net> From: Tom Honermann In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Classification-ID: 9ed4d611-fcd9-41a6-bb9d-fb4beaff0432-1-1 X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2022 01:38:18 -0000 On 7/25/22 2:05 PM, Andrew Pinski wrote: > On Mon, Jul 25, 2022 at 11:01 AM Tom Honermann via Gcc-patches > wrote: >> This patch corrects handling of UTF-8 character literals in preprocessing >> directives so that they are treated as unsigned types in char8_t enabled >> C++ modes (C++17 with -fchar8_t or C++20 without -fno-char8_t). Previously, >> UTF-8 character literals were always treated as having the same type as >> ordinary character literals (signed or unsigned dependent on target or use >> of the -fsigned-char or -funsigned char options). >> >> Fixes https://gcc.gnu.org/PR106426. > The above mention of the PR # should just be: > preprocessor/106426 > > And then when this patch gets committed, it will be recorded in bugzilla also. Thank you. I resent the patch with a revised subject line and commit message to reflect the component change in Bugzilla. Tom. > > Thanks, > Andrew Pinski >