From: Nathan Sidwell <nathan@acm.org>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
gcc-patches@gcc.gnu.org
Cc: jwakely@redhat.com, Yvan ROUX <yvan.roux@foss.st.com>
Subject: Re: [PATCH] testsuite: Colon is reserved on Windows
Date: Fri, 30 Sep 2022 07:12:01 -0400 [thread overview]
Message-ID: <48cb7d39-2ad9-9a68-92ed-be94a53ff080@acm.org> (raw)
In-Reply-To: <20220930081806.2252641-1-torbjorn.svensson@foss.st.com>
On 9/30/22 04:18, Torbjörn SVENSSON wrote:
> The ':' is reserved in filenames on Windows.
> Can't find any specification for this, but when there is no filename
> defined in the map file, GCC will replace the ':' with a '-' in the
> generated filename for the module.
Correct (and the specification is in the source code, there's no
requirement for any particular mapping, bu I was at least cognizant of
windows' dislike of : :)
>
> Without this patch, the test case failes with:
> .../ben-1_a.C:4:8: error: failed to write compiled module: Invalid argument
> .../ben-1_a.C:4:8: note: compiled module file is 'partitions/module:import.mod'
>
> gcc/testsuite:
>
> * g++.dg/modules/ben-1.map: Replace the colon with dash.
> * g++.dg/modules/ben-1_a.C: Likewise
ok, thanks
>
> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/testsuite/g++.dg/modules/ben-1.map | 2 +-
> gcc/testsuite/g++.dg/modules/ben-1_a.C | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/g++.dg/modules/ben-1.map b/gcc/testsuite/g++.dg/modules/ben-1.map
> index 182183ad089..ad84c11397d 100644
> --- a/gcc/testsuite/g++.dg/modules/ben-1.map
> +++ b/gcc/testsuite/g++.dg/modules/ben-1.map
> @@ -1,3 +1,3 @@
> $root .
> -module:import partitions/module:import.mod
> +module:import partitions/module-import.mod
> module module.mod
> diff --git a/gcc/testsuite/g++.dg/modules/ben-1_a.C b/gcc/testsuite/g++.dg/modules/ben-1_a.C
> index 7e9b5661026..f1562eb2c5a 100644
> --- a/gcc/testsuite/g++.dg/modules/ben-1_a.C
> +++ b/gcc/testsuite/g++.dg/modules/ben-1_a.C
> @@ -2,7 +2,7 @@
> // { dg-additional-files ben-1.map }
>
> export module module:import;
> -// { dg-module-cmi =partitions/module:import.mod }
> +// { dg-module-cmi =partitions/module-import.mod }
>
> export int b() {
> return 0;
--
Nathan Sidwell
prev parent reply other threads:[~2022-09-30 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 8:18 Torbjörn SVENSSON
2022-09-30 11:12 ` Nathan Sidwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48cb7d39-2ad9-9a68-92ed-be94a53ff080@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=torbjorn.svensson@foss.st.com \
--cc=yvan.roux@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).