From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 2B6C0385415D for ; Fri, 30 Sep 2022 11:12:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B6C0385415D Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x82c.google.com with SMTP id y2so2419386qtv.5 for ; Fri, 30 Sep 2022 04:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=7alpNtITOvFZaLD5wBbp6xug0BJYF381gIMQW0SrQ7I=; b=C0k92yZfTKAt5qDveXfaMrZm+Hv27t2nCEi3YQfUwP69ewyPuGIhYM/vM+P6sPDlvt RHo1PMgnUCAEPiQhJEoD81Tmwzix5T7KUZT/Ym1EYCr9obHf2oMt9JRda0rwHCtjuTtM TKpGJvthNt+wy0fVcsH9Ygd4eD2pLdsM3m1JdwZJUp8O/ewjA9TNbnwZNQG16IlUkYcl QuzWZmSTMY4AZsAdC9Z8t+KDXvsrt450mkRj9dLAWxOUmLsFyPTSrRZPVkfzHz95swbx 7s/y7n8jBo/vJBx0isZvs9ZTNNsd4xb6SFDL5weaawJpXqrbOJkRHS5jMpS0qGhZgAsY kLsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=7alpNtITOvFZaLD5wBbp6xug0BJYF381gIMQW0SrQ7I=; b=DJKvs3A/ihDg2peay1tr8VbTPAoA4sfvZqtOGCqETkBrA8OybGo53oO1ti7pEi9qdn aQEFWmViPK2vamgLio4gMu8zsOKVBZOTgsyJKFm/MNh25XAuvARmfl7erUBV/lVM9/oC 1Yb8iufQA/x1izDvf0h+l8vQoG2m6XbVL0/nF1VUWRrek6/YPcvvr2A/mwq0z0qkQDyA Oxn6Yt6SQBVPybo8tKMByzb2g8MeB10EzUVWVKWeqqh7gm4lxdDmk9X9XXyxbg6i9+49 Wjaa4aiSccj+nd9Gwr25R2WVnELlwlvTSHkNDPFb+wF4/Svl+sMqgi7rh0jhMNPtG71A 4oXA== X-Gm-Message-State: ACrzQf0pUyBUbDc1yq3WOrVEf8mKTlQKRBA481FpCYtbLEhRm3KmBvfQ wrHIvpqy8DoFw6Cb488InsA= X-Google-Smtp-Source: AMsMyM4wJSHqUbsBibK6VOp+bw5seyG6tdbXuR57W01EUug59lzqNu/yoHaEPYxg7222hU0feiPAvw== X-Received: by 2002:a05:622a:1316:b0:35b:b629:5247 with SMTP id v22-20020a05622a131600b0035bb6295247mr6154996qtk.275.1664536323458; Fri, 30 Sep 2022 04:12:03 -0700 (PDT) Received: from ?IPV6:2620:10d:c0a3:1407:e9fc:426f:f499:d6b9? ([2620:10d:c091:500::4:6881]) by smtp.googlemail.com with ESMTPSA id dm19-20020a05620a1d5300b006cbbc3daaacsm2328510qkb.113.2022.09.30.04.12.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 04:12:02 -0700 (PDT) Sender: Nathan Sidwell Message-ID: <48cb7d39-2ad9-9a68-92ed-be94a53ff080@acm.org> Date: Fri, 30 Sep 2022 07:12:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] testsuite: Colon is reserved on Windows To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gcc-patches@gcc.gnu.org Cc: jwakely@redhat.com, Yvan ROUX References: <20220930081806.2252641-1-torbjorn.svensson@foss.st.com> Content-Language: en-US From: Nathan Sidwell In-Reply-To: <20220930081806.2252641-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3039.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/30/22 04:18, Torbjörn SVENSSON wrote: > The ':' is reserved in filenames on Windows. > Can't find any specification for this, but when there is no filename > defined in the map file, GCC will replace the ':' with a '-' in the > generated filename for the module. Correct (and the specification is in the source code, there's no requirement for any particular mapping, bu I was at least cognizant of windows' dislike of : :) > > Without this patch, the test case failes with: > .../ben-1_a.C:4:8: error: failed to write compiled module: Invalid argument > .../ben-1_a.C:4:8: note: compiled module file is 'partitions/module:import.mod' > > gcc/testsuite: > > * g++.dg/modules/ben-1.map: Replace the colon with dash. > * g++.dg/modules/ben-1_a.C: Likewise ok, thanks > > Co-Authored-By: Yvan ROUX > Signed-off-by: Torbjörn SVENSSON > --- > gcc/testsuite/g++.dg/modules/ben-1.map | 2 +- > gcc/testsuite/g++.dg/modules/ben-1_a.C | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/g++.dg/modules/ben-1.map b/gcc/testsuite/g++.dg/modules/ben-1.map > index 182183ad089..ad84c11397d 100644 > --- a/gcc/testsuite/g++.dg/modules/ben-1.map > +++ b/gcc/testsuite/g++.dg/modules/ben-1.map > @@ -1,3 +1,3 @@ > $root . > -module:import partitions/module:import.mod > +module:import partitions/module-import.mod > module module.mod > diff --git a/gcc/testsuite/g++.dg/modules/ben-1_a.C b/gcc/testsuite/g++.dg/modules/ben-1_a.C > index 7e9b5661026..f1562eb2c5a 100644 > --- a/gcc/testsuite/g++.dg/modules/ben-1_a.C > +++ b/gcc/testsuite/g++.dg/modules/ben-1_a.C > @@ -2,7 +2,7 @@ > // { dg-additional-files ben-1.map } > > export module module:import; > -// { dg-module-cmi =partitions/module:import.mod } > +// { dg-module-cmi =partitions/module-import.mod } > > export int b() { > return 0; -- Nathan Sidwell