From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121625 invoked by alias); 22 Jun 2017 15:32:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 121594 invoked by uid 89); 22 Jun 2017 15:32:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 15:32:42 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9BB2930AF6D; Thu, 22 Jun 2017 15:32:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9BB2930AF6D Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9BB2930AF6D Received: from localhost.localdomain (ovpn-117-117.phx2.redhat.com [10.3.117.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 375745D967; Thu, 22 Jun 2017 15:32:41 +0000 (UTC) Subject: Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64 To: "Richard Earnshaw (lists)" , gcc-patches References: <76a8ccc4-c61d-b5fc-7d8a-175cb0bd2fc9@redhat.com> <4795a469-5292-e2ae-b3de-4d07b3ca3672@arm.com> From: Jeff Law Message-ID: <48ddd53e-7d8f-f3e1-5487-8e9842f0ba81@redhat.com> Date: Thu, 22 Jun 2017 15:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <4795a469-5292-e2ae-b3de-4d07b3ca3672@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01681.txt.bz2 On 06/22/2017 09:29 AM, Richard Earnshaw (lists) wrote: > On 22/06/17 16:01, Jeff Law wrote: >> This fixes a bug discovered when we were evaluating the current state of >> -fstack-check. It ought to be able to go forward independent of the >> rest of the -fstack-check work. >> >> The aarch64 specific code does not correctly handle large frames and >> will generate RTL with unrecognizable insns for such cases. This is >> clearly visible if -fstack-check is enabled by default or if it were to >> be added to the torture flags in the testsuite. >> >> I've tested this by bootstrapping and regression testing an aarch64 >> compiler with -fstack-check on by default and hacks to force all >> allocations/probing of more than PROBE_INTERVAL bytes to go through this >> path. It fixes a slew of testsuite failures (~80 for C and a few for >> Fortran and C++). >> >> >> One example is c-torture/compile/20031023-1.c which has a local frame of >> 0x10000000000 bytes. >> >> OK for the trunk? >> > > OK. But as Jakub says, a test would be nice. Sure. I'll do something with 20031023-1.c to ensure it or an equivalent is compiled with -fstack-check. That isn't totally unexpected. I would have also been receptive to adding -fstack-check to the torture flags. I'll cobble together the test side momentarily. jeff