From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15536 invoked by alias); 31 Oct 2008 01:30:19 -0000 Received: (qmail 15362 invoked by uid 22791); 31 Oct 2008 01:30:17 -0000 X-Spam-Check-By: sourceware.org Received: from mx10.gnu.org (HELO mx10.gnu.org) (199.232.76.166) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 31 Oct 2008 01:27:50 +0000 Received: from mx1.redhat.com ([66.187.233.31]:38968) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KvcVl-00039k-3c for gcc-patches@gcc.gnu.org; Thu, 30 Oct 2008 14:44:49 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m9UIecoD029223; Thu, 30 Oct 2008 14:40:38 -0400 Received: from omfg.slc.redhat.com (vpn-12-190.rdu.redhat.com [10.11.12.190]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m9UIeZa6007125; Thu, 30 Oct 2008 14:40:35 -0400 Message-ID: <4909FF11.7090009@redhat.com> Date: Fri, 31 Oct 2008 02:03:00 -0000 From: Jeff Law User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Peter Bergner CC: sje@cup.hp.com, luisgpm@linux.vnet.ibm.com, Andrew Pinski , Richard Henderson , gcc-patches@gcc.gnu.org, paolo.carlini@oracle.com Subject: Re: Patch to fix gcc.c-torture/compile/20010102-1.c on IA64 HP-UX References: <200809161651.m8GGpEM19079@lucas.cup.hp.com> <1221596846.17787.28.camel@hpsje.cup.hp.com> <48D0248E.5030505@redhat.com> <1221601143.17787.40.camel@hpsje.cup.hp.com> <48D2B834.7040701@redhat.com> <1221847674.4972.27.camel@hpsje.cup.hp.com> <48D953DC.6080200@redhat.com> <1222202669.19545.1.camel@hpsje.cup.hp.com> <1223062006.612.13.camel@gargoyle> <48E6BB7D.8000809@redhat.com> <1224182072.8846.94.camel@gargoyle> <48F78BD3.5080907@redhat.com> <1225370489.23514.9.camel@gargoyle> <1225389168.26118.11.camel@hpsje.cup.hp.com> <1225390882.6757.35.camel@otta> In-Reply-To: <1225390882.6757.35.camel@otta> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-10/txt/msg01322.txt.bz2 Peter Bergner wrote: > On Thu, 2008-10-30 at 10:52 -0700, Steve Ellcey wrote: > >> I don't want to just remove my patch but it might make sense to >> change regrename to only set the attributes (including pointer) for >> non-hard registers if that fixes your problem and doesn't cause a >> regression for me. >> > > I actually have already asked Luis to test that. My guess is that > is what we eventually will end up wanting to go with, but you might > then need to use the patch I posted for ia64/predicates.md, namely: > > Index: config/ia64/predicates.md > =================================================================== > --- config/ia64/predicates.md (revision 140417) > +++ config/ia64/predicates.md (working copy) > @@ -585,6 +585,6 @@ (define_predicate "ar_pfs_reg_operand" > (define_predicate "basereg_operand" > (match_operand 0 "register_operand") > { > - return REG_P (op) && REG_POINTER (op); > + return REG_P (op) && REG_POINTER (regno_reg_rtx[ORIGINAL_REGNO (op)]); > }) > > If you recall, that did solve the ICE you were hitting. The rerename.c > change was just handling a case that looked like should be handled, but > wasn't necessary for fixing your IC > We shouldn't be hacking up backends to deal with this problem, it's entirely the wrong approach. jeff