From: Bernd Schmidt <bernds_cb1@t-online.de>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Blackfin: Doloop optimization fix
Date: Mon, 03 Nov 2008 14:32:00 -0000 [thread overview]
Message-ID: <490F0A69.4020205@t-online.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
This is a problem introduced by some earlier changes I made to generate
more hardware loops on the Blackfin. In one case, with the following
structure:
...
jump point_inside_loop;
head:
do_stuff;
point_inside_loop:
do_some_more_stuff;
if condition jump head;
we would lose the initial jump into the loop; it was replaced by the
LSETUP instruction.
This patch fixes it. If do_some_more_stuff is simple enough, we emit it
after the LSETUP, otherwise we use a jump to the point inside the loop.
Committed as 141548.
Bernd
--
This footer brought to you by insane German lawmakers.
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 40368
Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
[-- Attachment #2: loopfix.diff --]
[-- Type: text/plain, Size: 2751 bytes --]
Index: ChangeLog
===================================================================
--- ChangeLog (revision 141547)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2008-11-03 Bernd Schmidt <bernd.schmidt@analog.com>
+
+ * config/bfin/bfin.c (bfin_optimize_loop): Properly handle case
+ where we have one entry point in the loop which isn't the head.
+
2008-11-03 Richard Guenther <rguenther@suse.de>
PR middle-end/37573
Index: config/bfin/bfin.c
===================================================================
--- config/bfin/bfin.c (revision 141547)
+++ config/bfin/bfin.c (working copy)
@@ -4059,12 +4059,33 @@ bfin_optimize_loop (loop_info loop)
print_rtl_single (dump_file, loop->loop_end);
}
+ /* Create a sequence containing the loop setup. */
start_sequence ();
if (loop->init != NULL_RTX)
emit_insn (loop->init);
seq_end = emit_insn (loop->loop_init);
+ /* If the loop isn't entered at the top, also create a jump to the entry
+ point. */
+ if (!loop->incoming_src && loop->head != loop->incoming_dest)
+ {
+ rtx label = BB_HEAD (loop->incoming_dest);
+ /* If we're jumping to the final basic block in the loop, and there's
+ only one cheap instruction before the end (typically an increment of
+ an induction variable), we can just emit a copy here instead of a
+ jump. */
+ if (loop->incoming_dest == loop->tail
+ && next_real_insn (label) == last_insn
+ && asm_noperands (last_insn) < 0
+ && GET_CODE (PATTERN (last_insn)) == SET)
+ {
+ seq_end = emit_insn (copy_rtx (PATTERN (last_insn)));
+ }
+ else
+ seq_end = emit_insn (gen_jump (label));
+ }
+
seq = get_insns ();
end_sequence ();
@@ -4084,21 +4105,19 @@ bfin_optimize_loop (loop_info loop)
basic_block new_bb;
edge e;
edge_iterator ei;
-
+
+#ifdef ENABLE_CHECKING
if (loop->head != loop->incoming_dest)
{
+ /* We aren't entering the loop at the top. Since we've established
+ that the loop is entered only at one point, this means there
+ can't be fallthru edges into the head. Any such fallthru edges
+ would become invalid when we insert the new block, so verify
+ that this does not in fact happen. */
FOR_EACH_EDGE (e, ei, loop->head->preds)
- {
- if (e->flags & EDGE_FALLTHRU)
- {
- rtx newjump = gen_jump (loop->start_label);
- emit_insn_before (newjump, BB_HEAD (loop->head));
- new_bb = create_basic_block (newjump, newjump, loop->head->prev_bb);
- gcc_assert (new_bb = loop->head->prev_bb);
- break;
- }
- }
+ gcc_assert (!(e->flags & EDGE_FALLTHRU));
}
+#endif
emit_insn_before (seq, BB_HEAD (loop->head));
seq = emit_label_before (gen_label_rtx (), seq);
reply other threads:[~2008-11-03 14:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490F0A69.4020205@t-online.de \
--to=bernds_cb1@t-online.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).