From: Jeff Law <law@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/3] selftest: show values when ASSERT_STREQ fails
Date: Mon, 13 Jun 2016 18:20:00 -0000 [thread overview]
Message-ID: <491ff663-0dc1-359a-7560-d1541a544859@redhat.com> (raw)
In-Reply-To: <1465497729-42544-2-git-send-email-dmalcolm@redhat.com>
On 06/09/2016 12:42 PM, David Malcolm wrote:
> Rework ASSERT_STREQ so that it prints the actual and expected values
> to stderr when it fails (by moving it to a helper function).
>
> gcc/ChangeLog:
> * selftest.c (selftest::fail_formatted): New function.
> (selftest::assert_streq): New function.
> * selftest.h (selftests::fail_formatted): New decl.
> (selftest::assert_streq): New decl.
> (ASSERT_STREQ): Reimplement in terms of selftest::assert_streq.
OK.
jeff
next prev parent reply other threads:[~2016-06-13 18:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 18:15 [PATCH 0/3] selftest improvements David Malcolm
2016-06-09 18:15 ` [PATCH 3/3] pretty-print.c: skip color selftests if GCC_COLORS is set David Malcolm
2016-06-13 18:20 ` Jeff Law
2016-06-09 18:15 ` [PATCH 1/3] selftest: show values when ASSERT_STREQ fails David Malcolm
2016-06-13 18:20 ` Jeff Law [this message]
2016-06-09 18:15 ` [PATCH 2/3] selftests: improve reported failure locations David Malcolm
2016-06-13 18:21 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491ff663-0dc1-359a-7560-d1541a544859@redhat.com \
--to=law@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).