From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96522 invoked by alias); 13 Jun 2016 18:20:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 96497 invoked by uid 89); 13 Jun 2016 18:20:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 18:20:01 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9DAAB3B716 for ; Mon, 13 Jun 2016 18:20:00 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-111.phx2.redhat.com [10.3.116.111]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DIK0DG012397; Mon, 13 Jun 2016 14:20:00 -0400 Subject: Re: [PATCH 1/3] selftest: show values when ASSERT_STREQ fails To: David Malcolm , gcc-patches@gcc.gnu.org References: <1465497729-42544-1-git-send-email-dmalcolm@redhat.com> <1465497729-42544-2-git-send-email-dmalcolm@redhat.com> From: Jeff Law Message-ID: <491ff663-0dc1-359a-7560-d1541a544859@redhat.com> Date: Mon, 13 Jun 2016 18:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1465497729-42544-2-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00988.txt.bz2 On 06/09/2016 12:42 PM, David Malcolm wrote: > Rework ASSERT_STREQ so that it prints the actual and expected values > to stderr when it fails (by moving it to a helper function). > > gcc/ChangeLog: > * selftest.c (selftest::fail_formatted): New function. > (selftest::assert_streq): New function. > * selftest.h (selftests::fail_formatted): New decl. > (selftest::assert_streq): New decl. > (ASSERT_STREQ): Reimplement in terms of selftest::assert_streq. OK. jeff