From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 09B803858D35 for ; Tue, 14 May 2024 18:45:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09B803858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09B803858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715712325; cv=none; b=wyPEpjEczgAR+3LkBeFUmjY9soci+g0M+B575aH/Pfce8o6osMyoztyUDS6LWjzgKC3waZz082J2rPFWRqKOk1HfXGkBgRYbJbune83t/xiIcQ1lH9APIahlgyLaxLAWpS1B2vbOt4RHRjJqFjeQN3mPlEt11kE+cqJF3CSf9gY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715712325; c=relaxed/simple; bh=S1HW8V5g4jNfjKyiryWuW6TlaoPe6AX3b50D6jjI4wA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=L9oQHP2+32m111Nmo2oQr3XVnxSSgrm4I5SvNTIuwgyNBsD7CUfa6uHqwMrbAGjEeY7gHlwu5NZZvK5rOIw/VJkVY2YxX2dPgq5KrvGlfuYZkZuyHQVlS/bQENn8zh6e5oECCmJ9WWWObuYI56ZMAUMul9A3/iDEwHwydY+5Cgw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715712322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V9b3IpVIgAyH+6SoPFl6Kb5oDrLsg0tEhoFqSVrgbv4=; b=MKxmF1/78rZNx/nNtYaKuHq0Yys/tIAY0h7J28mCG6UefPH5kYVv6WDtoW404PYYdnEg8V EETdP6jtIUU5tC22xBr5kNzJj+suVeU3EEcbJnbdaKjlbF5yVkGVMWXH3MiTCmTtFM/6Kv TBhAtCP64f3VqmNlcjkhuhuK04e24rk= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-5eQUHO8zM_euaD7XypYh_A-1; Tue, 14 May 2024 14:45:20 -0400 X-MC-Unique: 5eQUHO8zM_euaD7XypYh_A-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6a0b596f858so55075946d6.1 for ; Tue, 14 May 2024 11:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715712320; x=1716317120; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V9b3IpVIgAyH+6SoPFl6Kb5oDrLsg0tEhoFqSVrgbv4=; b=jp5xluuiWhnjebRiQEKrblRZiuaTK1FGMkY126UNDhiYbcKBoTO9GX8ISxL5qJ0gOV YwIgBsjMLfcuWziPK17Z9Ea1GMfqBbF1oQyZ5TjR3SHourMHyJFWHCHMBqEQJpRQqpsc fhJamyhGveh0f6TQd/YSEwujI5HagywTHS4YQIniwQq3rezjNlHPOBic38VR7IoWJgbY k1iwXGog7qrfuJgZgGK1UczT/LVvaJH8+wHTP692AFrGSaaOzVKLj99RB9OrQWgEtlUl RChfZcTXMcEHx756fRDQ1jOogWTGX1RtawOpSnK+6G6CiCFRnhKaRKH2GRPOTIf5AfRb Mn+Q== X-Forwarded-Encrypted: i=1; AJvYcCVW/e0wapWyv9PJ+1AgfF11aTe+HoOPJrL2pvpXTzG/fE9NDVOTcXdF+gStrR8lB06nDnszICqIaXgu+OP1n06WiKDclSXvoQ== X-Gm-Message-State: AOJu0YyyvKQgGQ8h9H1tqyTDxAaD8dxKE7vUIrEWLWNKH30jI1enUsAg ZtY6foL1/vfNQ25T3ZB2X/uagoyHdv7Yf7d+Z6wqP26nLiIOBRe5WZX/xqufUctn5i8RJcRoVyg e/wF4NHdzE/nek47dBhDcEyo1JZiKz9LKcuHOR+/qtNZfdRu/qsWOpPU= X-Received: by 2002:a05:6214:5705:b0:6a0:b3de:e3aa with SMTP id 6a1803df08f44-6a16822c978mr180949586d6.41.1715712320291; Tue, 14 May 2024 11:45:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGX4ANzHO4eu4AwPD4YnvTJaDnQRwRG0qrT2QzBu7jdr35/MfkC3JcOXxyaFMNCxgpFmBdR/A== X-Received: by 2002:a05:6214:5705:b0:6a0:b3de:e3aa with SMTP id 6a1803df08f44-6a16822c978mr180949266d6.41.1715712319786; Tue, 14 May 2024 11:45:19 -0700 (PDT) Received: from ?IPV6:2607:fea8:51db:5900::9ff8? ([2607:fea8:51db:5900::9ff8]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6a15f18520dsm56079236d6.44.2024.05.14.11.45.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 May 2024 11:45:19 -0700 (PDT) Message-ID: <49440bdc-4ab2-4811-b925-89a6777b4a7d@redhat.com> Date: Tue, 14 May 2024 14:45:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2] Value range: Add range op for __builtin_isfinite To: HAO CHEN GUI , Mikael Morin , gcc-patches Cc: Segher Boessenkool , David , "Kewen.Lin" , Peter Bergner , Aldy Hernandez References: <8a3f96a3-ce9b-48dc-b125-eaf1d832c79d@linux.ibm.com> <544aed62-5060-4421-b925-a9a4780c40fb@linux.ibm.com> From: Andrew MacLeod In-Reply-To: <544aed62-5060-4421-b925-a9a4780c40fb@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/9/24 04:47, HAO CHEN GUI wrote: > Hi Mikael, > > Thanks for your comments. > > 在 2024/5/9 16:03, Mikael Morin 写道: >> I think the canonical API behaviour sets R to varying and returns true instead of just returning false if nothing is known about the range. >> >> I'm not sure whether it makes any difference; Aldy can probably tell. But if the type is bool, varying is [0,1] which is better than unknown range. > Should the varying be set by caller when fold_range returns false? > Just like following codes in value-query.cc. > > if (!op.fold_range (r, type, r0, r1)) > r.set_varying (type); > This would be dangerous in the general case.  fold_range may have returned false because 'type' is an unsupported range type. Generally this is why we prefer range-ops to return TRUE and VARYING rather than FALSE for unknown values.   When FALSE is returned, we should stop working with ranges because something is amok. Andrew