[LTO] Patch to fix ICE in size_binop()

[LTO] Patch to fix ICE in size_binop()

[Doug Kwan (關振德)]

Hi

     This patch fixes an ICE found in size_binop() when running the C
testsuite. Could someone review this?

-Doug
-------------------------------------------------------
2007-11-07  Doug Kwan  <dougkwan@google.com>

        * lto.c (input_expr_operand): Change type of operand 2 of
        BIT_FIELD_REF expression to be bitsizetype instead of sizetype.

diff -dupr /disk2/dougkwan/lto-2/gcc/gcc/lto/lto-read.c lto/lto-read.c
--- /disk2/dougkwan/lto-2/gcc/gcc/lto/lto-read.c        2007-11-07
10:20:23.000000000 -0800
+++ lto/lto-read.c      2007-11-06 16:16:30.000000000 -0800
@@ -867,7 +867,7 @@ input_expr_operand (struct input_block *
        if (tag == LTO_bit_field_ref1)
          {
            op1 = build_int_cst_wide (sizetype, input_uleb128 (ib), 0);
-           op2 = build_int_cst_wide (sizetype, input_uleb128 (ib), 0);
+           op2 = build_int_cst_wide (bitsizetype, input_uleb128 (ib), 0);
            op0 = input_expr_operand (ib, data_in, fn,
                                      input_record_start (ib));
          }

Re: [LTO] Patch to fix ICE in size_binop()

[Diego Novillo]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GB2312, Size: 220 bytes --]

On Nov 7, 2007 1:34 PM, Doug Kwan (êPÕñµÂ) <dougkwan@google.com> wrote:

>         * lto.c (input_expr_operand): Change type of operand 2 of
>         BIT_FIELD_REF expression to be bitsizetype instead of sizetype.

OK.

problems with committed patch.

[Kenneth Zadeck]

The name of the file modified in the changelog is wrong.  This patch
really changes lto/lto-read.c.  Also, changes in files in the LTO
directory are supposed to go in lto/ChangeLog.

Please correct these problems.

The content of the patch, as approved by Diego, is otherwise ok.  

Kenny

> On Nov 7, 2007 1:34 PM, Doug Kwan (?~~) <dougkwan@google.com> wrote:
>
> >         * lto.c (input_expr_operand): Change type of operand 2 of
> >         BIT_FIELD_REF expression to be bitsizetype instead of sizetype.
> 
> OK.