[LTO][PATCH] Handle name in pointer and ref types

[LTO][PATCH] Handle name in pointer and ref types

[Doug Kwan (關振德)]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

Hi,

   Could someone review this? Internal pointer types created by gcc
can have names.  The current code in lto1 does not handle this
situation.  This patch does reasonable things to handle that
situation.

-Doug

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1184 bytes --]

2007-12-13  Doug Kwan  <dougkwan@google.com>

	* lto.c (lto_read_pointer_reference_type_DIE): Handle optional name
	in pointer and reference types.

Index: gcc/lto/lto.c
===================================================================
--- gcc/lto/lto.c	(revision 130927)
+++ gcc/lto/lto.c	(working copy)
@@ -2793,10 +2793,15 @@ lto_read_pointer_reference_type_DIE (lto
 				     lto_context *context)
 {
   tree pointed_to = NULL_TREE;
+  tree name = NULL_TREE;
   tree type;
 
   LTO_BEGIN_READ_ATTRS ()
     {
+    case DW_AT_name:
+      name = lto_get_identifier (&attr_data);
+      break;
+
     case DW_AT_type:
       pointed_to = lto_read_referenced_type_DIE (fd, 
 						 context, 
@@ -2830,6 +2835,16 @@ lto_read_pointer_reference_type_DIE (lto
       gcc_unreachable ();
     }
 
+  /* If pointer/reference has a name, build a typedef. */
+  if (name != NULL_TREE)
+    {
+      tree named_type = build_variant_type_copy (type);
+      tree decl = build_decl (TYPE_DECL, name, named_type);
+      TYPE_NAME (named_type) = decl;
+      DECL_ORIGINAL_TYPE (decl) = type;
+      type = named_type;
+    }
+
   lto_read_child_DIEs (fd, abbrev, context);
   return type;
 }

Re: [LTO][PATCH] Handle name in pointer and ref types

[Diego Novillo]

On 12/13/07 9:17 PM, Doug Kwan (關振德) wrote:

> 	* lto.c (lto_read_pointer_reference_type_DIE): Handle optional name
> 	in pointer and reference types.

OK.


Diego.

Re: [LTO][PATCH] Handle name in pointer and ref types

[Doug Kwan (關振德)]

committed to branch. Thanks.

-Doug

2007/12/14, Diego Novillo <dnovillo@google.com>:
> On 12/13/07 9:17 PM, Doug Kwan (關振德) wrote:
>
> >       * lto.c (lto_read_pointer_reference_type_DIE): Handle optional name
> >       in pointer and reference types.
>
> OK.
>
>
> Diego.
>
>