* Ping ---A bug with -fprofile-dir? Profile directory concatenated with object file path
@ 2019-10-02 16:07 Qing Zhao
2019-10-09 15:31 ` [PATCH][gcov-profile/91971]Profile " Qing Zhao
0 siblings, 1 reply; 6+ messages in thread
From: Qing Zhao @ 2019-10-02 16:07 UTC (permalink / raw)
To: hubicka; +Cc: gcc-patches
Ping on:
https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html <https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html>
Anyway, I filed an gcc bug on this issue as:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971 <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971>
If you think that this is NOT a bug, please let me know.
thanks.
Qing
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH][gcov-profile/91971]Profile directory concatenated with object file path
2019-10-02 16:07 Ping ---A bug with -fprofile-dir? Profile directory concatenated with object file path Qing Zhao
@ 2019-10-09 15:31 ` Qing Zhao
2019-10-14 14:53 ` PING: Fwd: " Qing Zhao
0 siblings, 1 reply; 6+ messages in thread
From: Qing Zhao @ 2019-10-09 15:31 UTC (permalink / raw)
To: hubicka; +Cc: gcc-patches
Hi,
This is a patch for fix PR 91971: Profile directory concatenated with object file path
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971
Gcc/ChangeLog:
+2019-10-09 qing zhao <qing.zhao@oracle.com>
+
+ * coverage.c (coverage_init): Mangle the full path of filename when
+ filename is a absolute path.
+
2019-10-07 Jozef Lawrynowicz <jozef.l@mittosystems.com>
$ git diff gcc/coverage.c
diff --git a/gcc/coverage.c b/gcc/coverage.c
index 0d5138f..bcba61c 100644
--- a/gcc/coverage.c
+++ b/gcc/coverage.c
@@ -1229,6 +1229,14 @@ coverage_init (const char *filename)
else
profile_data_prefix = getpwd ();
}
+ else
+ {
+ /* when filename is a absolute path, we also need to mangle the full
+ path of filename to prevent the profiling data being stored into a
+ different path than that specified by profile_data_prefix. */
+ filename = mangle_path (filename);
+ len = strlen (filename);
+ }
if (profile_data_prefix)
prefix_len = strlen (profile_data_prefix);
Okay to commit?
thanks.
Qing
> On Oct 2, 2019, at 11:05 AM, Qing Zhao <qing.zhao@oracle.com> wrote:
>
> Ping on:
>
> https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html <https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html>
>
> Anyway, I filed an gcc bug on this issue as:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971 <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971>
>
> If you think that this is NOT a bug, please let me know.
>
> thanks.
>
> Qing
^ permalink raw reply [flat|nested] 6+ messages in thread* PING: Fwd: [PATCH][gcov-profile/91971]Profile directory concatenated with object file path
2019-10-09 15:31 ` [PATCH][gcov-profile/91971]Profile " Qing Zhao
@ 2019-10-14 14:53 ` Qing Zhao
2019-10-21 15:46 ` PING*2 : " Qing Zhao
0 siblings, 1 reply; 6+ messages in thread
From: Qing Zhao @ 2019-10-14 14:53 UTC (permalink / raw)
To: hubicka; +Cc: gcc-patches
Hi,
This is a ping to the following patch.
Thanks,
Qing
> Begin forwarded message:
>
> From: Qing Zhao <QING.ZHAO@ORACLE.COM>
> Subject: [PATCH][gcov-profile/91971]Profile directory concatenated with object file path
> Date: October 9, 2019 at 10:30:04 AM CDT
> To: hubicka@ucw.cz
> Cc: gcc-patches@gcc.gnu.org
>
> Hi,
>
> This is a patch for fix PR 91971: Profile directory concatenated with object file path
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971
>
> Gcc/ChangeLog:
>
> +2019-10-09 qing zhao <qing.zhao@oracle.com>
> +
> + * coverage.c (coverage_init): Mangle the full path of filename when
> + filename is a absolute path.
> +
> 2019-10-07 Jozef Lawrynowicz <jozef.l@mittosystems.com>
>
> $ git diff gcc/coverage.c
> diff --git a/gcc/coverage.c b/gcc/coverage.c
> index 0d5138f..bcba61c 100644
> --- a/gcc/coverage.c
> +++ b/gcc/coverage.c
> @@ -1229,6 +1229,14 @@ coverage_init (const char *filename)
> else
> profile_data_prefix = getpwd ();
> }
> + else
> + {
> + /* when filename is a absolute path, we also need to mangle the full
> + path of filename to prevent the profiling data being stored into a
> + different path than that specified by profile_data_prefix. */
> + filename = mangle_path (filename);
> + len = strlen (filename);
> + }
>
> if (profile_data_prefix)
> prefix_len = strlen (profile_data_prefix);
>
> Okay to commit?
>
> thanks.
>
> Qing
>
>
>> On Oct 2, 2019, at 11:05 AM, Qing Zhao <qing.zhao@oracle.com> wrote:
>>
>> Ping on:
>>
>> https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html <https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html>
>>
>> Anyway, I filed an gcc bug on this issue as:
>>
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971 <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971>
>>
>> If you think that this is NOT a bug, please let me know.
>>
>> thanks.
>>
>> Qing
>
^ permalink raw reply [flat|nested] 6+ messages in thread* PING*2 : Fwd: [PATCH][gcov-profile/91971]Profile directory concatenated with object file path
2019-10-14 14:53 ` PING: Fwd: " Qing Zhao
@ 2019-10-21 15:46 ` Qing Zhao
2019-10-23 10:28 ` Martin Liška
0 siblings, 1 reply; 6+ messages in thread
From: Qing Zhao @ 2019-10-21 15:46 UTC (permalink / raw)
To: hubicka, gcc-patches
Hi,
This is 2nd ping of this simple patch.
We are waiting for this patch for one of our important project.
Please let me know whether this patch is reasonable or not.
Thanks a lot.
Qing
> Begin forwarded message:
>
> From: Qing Zhao <QING.ZHAO@ORACLE.COM>
> Subject: PING: Fwd: [PATCH][gcov-profile/91971]Profile directory concatenated with object file path
> Date: October 14, 2019 at 9:52:34 AM CDT
> To: hubicka@ucw.cz
> Cc: gcc-patches@gcc.gnu.org
>
> Hi,
>
> This is a ping to the following patch.
>
> Thanks,
>
> Qing
>
>> Begin forwarded message:
>>
>> From: Qing Zhao <QING.ZHAO@ORACLE.COM>
>> Subject: [PATCH][gcov-profile/91971]Profile directory concatenated with object file path
>> Date: October 9, 2019 at 10:30:04 AM CDT
>> To: hubicka@ucw.cz
>> Cc: gcc-patches@gcc.gnu.org
>>
>> Hi,
>>
>> This is a patch for fix PR 91971: Profile directory concatenated with object file path
>>
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971
>>
>> Gcc/ChangeLog:
>>
>> +2019-10-09 qing zhao <qing.zhao@oracle.com>
>> +
>> + * coverage.c (coverage_init): Mangle the full path of filename when
>> + filename is a absolute path.
>> +
>> 2019-10-07 Jozef Lawrynowicz <jozef.l@mittosystems.com>
>>
>> $ git diff gcc/coverage.c
>> diff --git a/gcc/coverage.c b/gcc/coverage.c
>> index 0d5138f..bcba61c 100644
>> --- a/gcc/coverage.c
>> +++ b/gcc/coverage.c
>> @@ -1229,6 +1229,14 @@ coverage_init (const char *filename)
>> else
>> profile_data_prefix = getpwd ();
>> }
>> + else
>> + {
>> + /* when filename is a absolute path, we also need to mangle the full
>> + path of filename to prevent the profiling data being stored into a
>> + different path than that specified by profile_data_prefix. */
>> + filename = mangle_path (filename);
>> + len = strlen (filename);
>> + }
>>
>> if (profile_data_prefix)
>> prefix_len = strlen (profile_data_prefix);
>>
>> Okay to commit?
>>
>> thanks.
>>
>> Qing
>>
>>
>>> On Oct 2, 2019, at 11:05 AM, Qing Zhao <qing.zhao@oracle.com> wrote:
>>>
>>> Ping on:
>>>
>>> https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html <https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html>
>>>
>>> Anyway, I filed an gcc bug on this issue as:
>>>
>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971 <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971>
>>>
>>> If you think that this is NOT a bug, please let me know.
>>>
>>> thanks.
>>>
>>> Qing
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-23 18:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 16:07 Ping ---A bug with -fprofile-dir? Profile directory concatenated with object file path Qing Zhao
2019-10-09 15:31 ` [PATCH][gcov-profile/91971]Profile " Qing Zhao
2019-10-14 14:53 ` PING: Fwd: " Qing Zhao
2019-10-21 15:46 ` PING*2 : " Qing Zhao
2019-10-23 10:28 ` Martin Liška
2019-10-23 18:20 ` Qing Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).