From: Mark Mitchell <mark@codesourcery.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
Nathan Sidwell <nathan@codesourcery.com>
Subject: Re: [C/C++] PR 13358 long long and C++ do not mix well
Date: Mon, 20 Apr 2009 03:34:00 -0000 [thread overview]
Message-ID: <49EBED41.6070609@codesourcery.com> (raw)
In-Reply-To: <6c33472e0904190416g1bff083j5a2a6e73640364f7@mail.gmail.com>
Manuel López-Ibáñez wrote:
> PING2: http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00842.html
> +/* Issue an ISO C++98 pedantic warning MSGID. This function is supposed to
> + be used for matters that are allowed in ISO C++0x but not supported in
> + ISO C++98, thus we explicitly don't pedwarn when ISO c++0x is specified. */
This comment needs work. The parameter is GMSGID. There are two other
parameters not mentioned. The ", thus" is a run-on sentence. "is
supposed to be" is inappropriate in an interface specification. Please
replace the last two sentences with:
Use this function to report diagnostics for constructs that are
invalid C++98, but valid C++0x.
and document the other parameters.
OK with that change.
It's in no way material to this patch, but I wish you would not put so
much of the error text into test-cases. I realize that you feel it's
important to test the exact message, but I feel that this just creates a
disincentive to make small changes to improve the text of a message.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
next prev parent reply other threads:[~2009-04-20 3:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-30 1:11 Manuel López-Ibáñez
2008-08-30 2:15 ` Joseph S. Myers
2008-08-30 9:52 ` Manuel López-Ibáñez
2008-10-23 2:42 ` Manuel López-Ibáñez
2009-04-10 19:12 ` Manuel López-Ibáñez
2009-04-10 21:41 ` Joseph S. Myers
2009-04-19 11:16 ` Manuel López-Ibáñez
2009-04-20 3:34 ` Mark Mitchell [this message]
2009-04-20 8:38 ` Manuel López-Ibáñez
2009-04-20 15:14 ` Mark Mitchell
2009-04-20 16:17 ` Manuel López-Ibáñez
2009-04-20 16:26 ` Mark Mitchell
2009-04-20 17:38 ` Jason Merrill
2009-04-23 9:15 ` Dave Korn
2009-04-23 23:46 ` Mark Mitchell
2009-04-24 13:39 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EBED41.6070609@codesourcery.com \
--to=mark@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=lopezibanez@gmail.com \
--cc=nathan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).