From: Mark Mitchell <mark@codesourcery.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
Nathan Sidwell <nathan@codesourcery.com>,
Janis Johnson <janis187@us.ibm.com>
Subject: Re: [C/C++] PR 13358 long long and C++ do not mix well
Date: Mon, 20 Apr 2009 15:14:00 -0000 [thread overview]
Message-ID: <49EC9148.9070806@codesourcery.com> (raw)
In-Reply-To: <6c33472e0904200138n73a3a3c6l779fc89d0fcff39f@mail.gmail.com>
Manuel López-Ibáñez wrote:
> After fixing the C testsuite to distinguish between errors and
> warnings, I have the completely opposite opinion. If one wants to
> change an error text, it is better to have as much text as possible to
> do a find + sed and replace everything in one go. If one does not have
> any text, a logic change can start producing nonsense and no one will
> notice.
There is an intermediate position between just:
// { dg-error "" }
which matches anything, and which I agree is sloppy (though I added
plenty such tests over the years) and putting the entire text there.
It's generally possible to pick out a few key words from the error
message ("invalid overload" or "does not match" or "private" or some
such) that are the important part of the error message.
> Nonetheless, you are the maintainer, so if you want me to cut the test
> pattern, tell me what I should match and I will update the patch.
I'm not going to make you change a perfectly good patch just for this.
But, unless Jason/Nathan indicate otherwise, I'd appreciate it if for
future patches you take a more circumspect approach.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
next prev parent reply other threads:[~2009-04-20 15:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-30 1:11 Manuel López-Ibáñez
2008-08-30 2:15 ` Joseph S. Myers
2008-08-30 9:52 ` Manuel López-Ibáñez
2008-10-23 2:42 ` Manuel López-Ibáñez
2009-04-10 19:12 ` Manuel López-Ibáñez
2009-04-10 21:41 ` Joseph S. Myers
2009-04-19 11:16 ` Manuel López-Ibáñez
2009-04-20 3:34 ` Mark Mitchell
2009-04-20 8:38 ` Manuel López-Ibáñez
2009-04-20 15:14 ` Mark Mitchell [this message]
2009-04-20 16:17 ` Manuel López-Ibáñez
2009-04-20 16:26 ` Mark Mitchell
2009-04-20 17:38 ` Jason Merrill
2009-04-23 9:15 ` Dave Korn
2009-04-23 23:46 ` Mark Mitchell
2009-04-24 13:39 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EC9148.9070806@codesourcery.com \
--to=mark@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janis187@us.ibm.com \
--cc=jason@redhat.com \
--cc=lopezibanez@gmail.com \
--cc=nathan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).