From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17835 invoked by alias); 20 Apr 2009 15:14:35 -0000 Received: (qmail 17824 invoked by uid 22791); 20 Apr 2009 15:14:34 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_FAIL X-Spam-Check-By: sourceware.org Received: from mx20.gnu.org (HELO mx20.gnu.org) (199.232.41.8) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Apr 2009 15:14:27 +0000 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LvvCS-0001UB-L7 for gcc-patches@gcc.gnu.org; Mon, 20 Apr 2009 11:14:24 -0400 Received: (qmail 14035 invoked from network); 20 Apr 2009 15:14:23 -0000 Received: from unknown (HELO ?192.168.0.2?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Apr 2009 15:14:23 -0000 Message-ID: <49EC9148.9070806@codesourcery.com> Date: Mon, 20 Apr 2009 15:14:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Manuel_L=F3pez-Ib=E1=F1ez?= CC: Gcc Patch List , Jason Merrill , Nathan Sidwell , Janis Johnson Subject: Re: [C/C++] PR 13358 long long and C++ do not mix well References: <6c33472e0808281543w5d464fe6r1fa5e584797ac46c@mail.gmail.com> <6c33472e0808281700m457e1f2euf6a0da108dd5b84a@mail.gmail.com> <6c33472e0810221705u1286ac46g166ec57677fe0f4c@mail.gmail.com> <6c33472e0904101212j69a8aa48hb12369c0aeb55242@mail.gmail.com> <6c33472e0904190416g1bff083j5a2a6e73640364f7@mail.gmail.com> <49EBED41.6070609@codesourcery.com> <6c33472e0904200138n73a3a3c6l779fc89d0fcff39f@mail.gmail.com> In-Reply-To: <6c33472e0904200138n73a3a3c6l779fc89d0fcff39f@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-04/txt/msg01562.txt.bz2 Manuel López-Ibáñez wrote: > After fixing the C testsuite to distinguish between errors and > warnings, I have the completely opposite opinion. If one wants to > change an error text, it is better to have as much text as possible to > do a find + sed and replace everything in one go. If one does not have > any text, a logic change can start producing nonsense and no one will > notice. There is an intermediate position between just: // { dg-error "" } which matches anything, and which I agree is sloppy (though I added plenty such tests over the years) and putting the entire text there. It's generally possible to pick out a few key words from the error message ("invalid overload" or "does not match" or "private" or some such) that are the important part of the error message. > Nonetheless, you are the maintainer, so if you want me to cut the test > pattern, tell me what I should match and I will update the patch. I'm not going to make you change a perfectly good patch just for this. But, unless Jason/Nathan indicate otherwise, I'd appreciate it if for future patches you take a more circumspect approach. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713