public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Dave Korn <dave.korn.cygwin@googlemail.com>
Cc: "Jason Merrill" <jason@redhat.com>,
	"Manuel López-Ibáñez" <lopezibanez@gmail.com>,
	"Gcc Patch List" <gcc-patches@gcc.gnu.org>,
	"Nathan Sidwell" <nathan@codesourcery.com>,
	"Janis Johnson" <janis187@us.ibm.com>
Subject: Re: [C/C++] PR 13358 long long and C++ do not mix well
Date: Thu, 23 Apr 2009 23:46:00 -0000	[thread overview]
Message-ID: <49F0FB46.8020202@codesourcery.com> (raw)
In-Reply-To: <49F03209.3080907@gmail.com>

Dave Korn wrote:

> /tmp/string-null-ctor.C:9: warning: null argument where non-null required
> (argument 1)
> 
>   Would either of you care to comment on what would be a suitable pattern to test?

I'd just say "null".  Or maybe "null pointer" (see below).

As a nit-pick on the message, and without having much context, I suggest
something like

  warning: argument is the null pointer

That's because (a) I like using terms of the standard, and "the null
pointer" is a term from the standard, where as just plain "null" isn't,
(b) once you point out it's null, I don't think you add much by saying
that what you want is something non-null.

As for the test question, to me "null" is the key word here.  Any good
warning message for this situation will say "null", and any message
that's talking about "null" is probably saying something useful.

My two cents,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

  reply	other threads:[~2009-04-23 23:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-30  1:11 Manuel López-Ibáñez
2008-08-30  2:15 ` Joseph S. Myers
2008-08-30  9:52   ` Manuel López-Ibáñez
2008-10-23  2:42     ` Manuel López-Ibáñez
2009-04-10 19:12       ` Manuel López-Ibáñez
2009-04-10 21:41         ` Joseph S. Myers
2009-04-19 11:16           ` Manuel López-Ibáñez
2009-04-20  3:34             ` Mark Mitchell
2009-04-20  8:38               ` Manuel López-Ibáñez
2009-04-20 15:14                 ` Mark Mitchell
2009-04-20 16:17                   ` Manuel López-Ibáñez
2009-04-20 16:26                     ` Mark Mitchell
2009-04-20 17:38                       ` Jason Merrill
2009-04-23  9:15                         ` Dave Korn
2009-04-23 23:46                           ` Mark Mitchell [this message]
2009-04-24 13:39                             ` Dave Korn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F0FB46.8020202@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=dave.korn.cygwin@googlemail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=janis187@us.ibm.com \
    --cc=jason@redhat.com \
    --cc=lopezibanez@gmail.com \
    --cc=nathan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).