From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 23E62383301C for ; Tue, 1 Dec 2020 21:47:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23E62383301C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-JEG5IAEUMHyhFYe2mhV2dQ-1; Tue, 01 Dec 2020 16:47:34 -0500 X-MC-Unique: JEG5IAEUMHyhFYe2mhV2dQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C6F7185E486; Tue, 1 Dec 2020 21:47:33 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-145.phx2.redhat.com [10.3.112.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id E213210013BD; Tue, 1 Dec 2020 21:47:32 +0000 (UTC) Subject: Re: [ Preprocessor ] [ Common ] Feature: Macros for identifying the wide and narrow execution string literal encoding To: JeanHeyd Meneide Cc: Bernhard Reutner-Fischer , JeanHeyd Meneide via Gcc-patches , Joseph Myers References: <9F4AE870-69D6-4152-A558-61F0A3F61441@gmail.com> <7dd57cee-bc5b-d68c-ca89-d70bc7ebbc7f@redhat.com> From: Jeff Law Message-ID: <49a4711a-ed35-da64-c5d7-290b45a05469@redhat.com> Date: Tue, 1 Dec 2020 14:47:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2020 21:47:38 -0000 On 11/23/20 1:40 PM, JeanHeyd Meneide wrote: > Dear Jeff, > > On Mon, Nov 23, 2020 at 3:02 PM Jeff Law wrote: >> You use a getter function to retrieve the value of ret.to, which is >> fine. Is there a specific reason why you're not using a setter function >> to save the value? > I did this because I have access to ret.to in the libcpp > functions! Outside, the structure of that type is unknown and only a > pointer, so it needs the getter function. Thanks.  I've fixed up the ChangeLog entry and pushed the patch to the trunk. Jeff