public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] RISC-V: Enable vect test for RV32
@ 2023-12-18  6:52 Juzhe-Zhong
  2023-12-18  9:08 ` Robin Dapp
  0 siblings, 1 reply; 2+ messages in thread
From: Juzhe-Zhong @ 2023-12-18  6:52 UTC (permalink / raw)
  To: gcc-patches; +Cc: kito.cheng, kito.cheng, jeffreyalaw, rdapp.gcc, Juzhe-Zhong

After recent fixes, almost all real FAILs on RV64 full coverage testing are fixed.

So, it's reasonable to start test RV32 vect testing now.

We will enable full coverage testing RV32 soon and to see what else need to be fixed.

gcc/testsuite/ChangeLog:

	* lib/target-supports.exp: Enable RV32 vect testing.

---
 gcc/testsuite/lib/target-supports.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index bd38d72562d..5925457d343 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -11569,7 +11569,7 @@ proc check_vect_support_and_set_flags { } {
         }
     } elseif [istarget amdgcn-*-*] {
         set dg-do-what-default run
-    } elseif [istarget riscv64-*-*] {
+    } elseif [istarget riscv*-*-*] {
 	if [check_effective_target_riscv_v] {
 	    lappend DEFAULT_VECTCFLAGS "--param" "riscv-vector-abi"
 	    set dg-do-what-default run
-- 
2.36.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] RISC-V: Enable vect test for RV32
  2023-12-18  6:52 [PATCH] RISC-V: Enable vect test for RV32 Juzhe-Zhong
@ 2023-12-18  9:08 ` Robin Dapp
  0 siblings, 0 replies; 2+ messages in thread
From: Robin Dapp @ 2023-12-18  9:08 UTC (permalink / raw)
  To: Juzhe-Zhong, gcc-patches; +Cc: rdapp.gcc, kito.cheng, kito.cheng, jeffreyalaw

Hi Juzhe,

> -    } elseif [istarget riscv64-*-*] {
> +    } elseif [istarget riscv*-*-*] {
>  	if [check_effective_target_riscv_v] {
>  	    lappend DEFAULT_VECTCFLAGS "--param" "riscv-vector-abi"
>  	    set dg-do-what-default run

Yes, that's reasonable.  A bit further down we have

	} else {
	    lappend DEFAULT_VECTCFLAGS "-march=rv64gcv_zvfh" "-mabi=lp64d"
	    lappend DEFAULT_VECTCFLAGS "--param" "riscv-autovec-preference=scalable"
	    lappend DEFAULT_VECTCFLAGS "--param" "riscv-vector-abi"

though and I wonder if we wouldn't rather want to use rv32gcv as well in the
rv32 case.

Something like the following:

@@ -11574,7 +11575,9 @@ proc check_vect_support_and_set_flags { } {
            lappend DEFAULT_VECTCFLAGS "--param" "riscv-vector-abi"
            set dg-do-what-default run
        } else {
-           lappend DEFAULT_VECTCFLAGS "-march=rv64gcv_zvfh" "-mabi=lp64d"
-           lappend DEFAULT_VECTCFLAGS "--param" "riscv-autovec-preference=scalable"
+           foreach item [add_options_for_riscv_v ""] {
+               lappend DEFAULT_VECTCFLAGS $item
+           }

should do it?  We don't need to add scalable anymore I suppose.

Regards
 Robin


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-18  9:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-18  6:52 [PATCH] RISC-V: Enable vect test for RV32 Juzhe-Zhong
2023-12-18  9:08 ` Robin Dapp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).