From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124668 invoked by alias); 13 Sep 2018 14:58:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124647 invoked by uid 89); 13 Sep 2018 14:58:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Sep 2018 14:58:36 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1g0T4k-0007a1-A8 from Andrew_Stubbs@mentor.com ; Thu, 13 Sep 2018 07:58:34 -0700 Received: from [172.30.89.86] (137.202.0.90) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 13 Sep 2018 15:58:29 +0100 Subject: Re: [PATCH 04/25] SPECIAL_REGNO_P To: Paul Koning CC: GCC patches References: <85ef6d30-228a-af0f-55ef-dfde8e89f36f@redhat.com> <1480c0db-e2c0-5eef-40a8-f7f03f3283af@codesourcery.com> <7d48dfd2-83b7-2200-4304-ed4349d60c54@codesourcery.com> <7a956a43-09c0-4fa5-6cf9-1e761fa80c13@codesourcery.com> From: Andrew Stubbs Message-ID: <49d432ba-403a-30d7-2e67-14e61a06650f@codesourcery.com> Date: Thu, 13 Sep 2018 15:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00702.txt.bz2 On 13/09/18 15:49, Paul Koning wrote: > It's ambiguous, because the last sentence of that paragraph says "addm3 is used if addptrm3 is not defined." I didn't read that as ambiguous; I read it as addm3 is assumed to work fine when addptr is not defined. > I don't know of any change in this area. All I know is that pdp11 has adds that clobber CC and it doesn't define addptrm3, relying on that last sentence. I've tried LRA and for the most part it compiles successfully, I suppose I should verify the generated code based on the point you raised. If I really have to define addptr, I'm in trouble because save/restore CC is not easy on pdp11. The code was added because we had a number of testcases that failed at runtime without it. Admittedly, that was in a GCC 7 code-base, and I can't reproduce the failure with one of those test cases now (with addptr deleted), but possibly that's just noise. Andrew