From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 74EF9385041A for ; Thu, 20 Oct 2022 15:39:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74EF9385041A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666280369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6KDiohGxmwQlcr+C2EPJ8/efBcyOrtKLQ9XT4beKBZs=; b=ghS96DPAY1i9k2NrlR9VlqRLs1OIrFGEPcUE48fu+Y0F4OIIoT9Nh2IWo5bteBphhkx4su DiQFLuqbMNhcgy8+0OLQjbsVuy+H/sDO7azI1HQ8owk0rGJsI7Il9kxevxKYk5PrNj+5jP mLwp5uxHoI1iiS1aN/9yVrwSRLZINfA= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-397-6eMkZnOcOYyj0ZGsQYAbFQ-1; Thu, 20 Oct 2022 11:39:28 -0400 X-MC-Unique: 6eMkZnOcOYyj0ZGsQYAbFQ-1 Received: by mail-qt1-f198.google.com with SMTP id bz12-20020a05622a1e8c00b0039ae6e887ffso15259026qtb.8 for ; Thu, 20 Oct 2022 08:39:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6KDiohGxmwQlcr+C2EPJ8/efBcyOrtKLQ9XT4beKBZs=; b=In7/J1OabJiJ8Ab6RlDnmUFx3UEABL50J30OCKqby3YjVcyix2rM1p7G0xldVw1xKH AdYkwXaqXV4t3t2y8FCIl4kbd4Fa46I2kTLAZBiGC1fZQfO2L9wu1llaM/5jnP+WMdMq V95dO8jWojniLcVyp91/LUtoTjO2/zr3MNxp9fQ8dEj6Pmi/WVWPeaYcVbAPAuT7g0NA jwy7PTC5bqUrsXv4HNesjdnASHEDRtUAYs8WPlHAdfCRJE0ay+DBVgd86umb9IERE/4W Sllnx3/6RX41fqeHUSP6iYHmdESvLZofQBv1w+f+P5TG4+zTf9nKz1cm4mmHO6qfQUer 7kyQ== X-Gm-Message-State: ACrzQf0dxH6EsiJZEMdGq9vuhzshhVSpPMeLBxAI7P4HkMrlXzIHqBM1 yc0kvEaAR9y50kAvZXk7EPxzVseQl5xXq2nbfLAX7NXrq9GUByGnFSmZgI7pO6spqngmbCKJSBt gTdTtZWr8JML35aiolg== X-Received: by 2002:ac8:5a43:0:b0:39c:c4ec:636d with SMTP id o3-20020ac85a43000000b0039cc4ec636dmr11589200qta.87.1666280367586; Thu, 20 Oct 2022 08:39:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Ft/8jJfucUHlapLZgat8hzClxbyEJ6cLiVhO8eY8PnNz+IdlyFsdyEw0VzFe+7VxN/s95hw== X-Received: by 2002:ac8:5a43:0:b0:39c:c4ec:636d with SMTP id o3-20020ac85a43000000b0039cc4ec636dmr11589175qta.87.1666280367293; Thu, 20 Oct 2022 08:39:27 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id w29-20020a05620a0e9d00b006ee7e223bb8sm7465540qkm.39.2022.10.20.08.39.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 08:39:26 -0700 (PDT) Message-ID: <49eb01df-8da3-c5fb-f2c2-864c6c7dc227@redhat.com> Date: Thu, 20 Oct 2022 11:39:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH RESEND 1/1] p1689r5: initial support To: Ben Boeckel Cc: Ben Boeckel , gcc-patches@gcc.gnu.org, nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com References: <20221004151200.1275636-1-ben.boeckel@kitware.com> <20221004151200.1275636-2-ben.boeckel@kitware.com> <78b88b1d-b328-a140-3a27-d33a3d96f3b9@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/18/22 08:18, Ben Boeckel wrote: > On Tue, Oct 11, 2022 at 07:42:43 -0400, Ben Boeckel wrote: >> On Mon, Oct 10, 2022 at 17:04:09 -0400, Jason Merrill wrote: >>> Can we share utf8 parsing code with decode_utf8_char in pretty-print.cc? >> >> I can look at factoring that out. I'll have to decode its logic to see >> how much overlap there is. > > There is some mismatch. First, that is in `gcc` and this is in `libcpp`. Oops, I was thinking this was in gcc as well. In libcpp there's _cpp_valid_utf8 (which calls one_utf8_to_cppchar). Jason