From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18828 invoked by alias); 5 Sep 2009 18:11:49 -0000 Received: (qmail 18818 invoked by uid 22791); 5 Sep 2009 18:11:48 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Sep 2009 18:11:40 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n85IBbuw029136; Sat, 5 Sep 2009 14:11:37 -0400 Received: from stone.twiddle.home (vpn-8-244.rdu.redhat.com [10.11.8.244]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n85IBZcq006149; Sat, 5 Sep 2009 14:11:36 -0400 Message-ID: <4AA2A9D7.3030406@redhat.com> Date: Sat, 05 Sep 2009 18:11:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Richard Guenther CC: gcc-patches@gcc.gnu.org, Diego Novillo Subject: Re: [PATCH] Merge from LTO: eh_personality changes References: <4AA293E4.8090301@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-09/txt/msg00411.txt.bz2 On 09/05/2009 10:24 AM, Richard Guenther wrote: >> Also, I think you need to add something to prevent inlining of functions >> that use different personality functions. > > I don't think so. The IL should be still in a state where the inlined > pieces would simply inherit the callers personality. But maybe I'm > missing something? You're missing that the personality functions have to deal with the language's runtime types, as recorded in the catch type_list and the allowed-exceptions type_list. You can't expect the Ada personality to deal with C++ runtime types. >> Do you have a strategy for handling >> >> if (targetm.arm_eabi_unwinder) >> unwind_resume_libfunc = init_one_libfunc ("__cxa_end_cleanup"); >> >> since this function is only used for c++/java? > > No. Do you have something in mind? The only thing I can think of is to record the fact that the GIMPLE_TRY came from c++/java in the eh_region tree, which would allow the RESX expander to emit the proper function for this particular region. It's not elegant, but it should work. > I see the patch is somewhat incomplete (there's also > lang_eh_runtime_type, but maybe we never call add_type_for_runtime > after a frontend finishes - in which case this should have been > a langhook?) - and in general the integration of EH aware and > non-EH aware code with LTO still needs work and thought. We do all the calls to add_type_for_runtime during pass_lower_eh, right toward the beginning of compilation. I'm pretty sure we don't need to do anything else with that lang hook for LTO. r~