public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: Richard Guenther <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, Diego Novillo <dnovillo@google.com>
Subject: Re: [PATCH] Merge from LTO: eh_personality changes
Date: Tue, 08 Sep 2009 15:48:00 -0000	[thread overview]
Message-ID: <4AA67CD1.8020602@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0909081435050.28140@zhemvz.fhfr.qr>

On 09/08/2009 05:37 AM, Richard Guenther wrote:
> Hmm, ok.  So how about setting DECL_EH_PERSONALITY during eh-lowering
> and only for functions with a non-empty EH tree.  We then would
> disallow inlining functions with different non-NULL personality.

I suppose we could do better than that -- only record the
personality if there are runtime types involved.  So that
if there are only cleanups we don't prevent merging.  And
if we get to the end and find personality is still unset,
then we can use the default C personality from libgcc.

I might think we'd record this in cfun->eh, not on the
decl though...

>> The only thing I can think of is to record the fact that the
>> GIMPLE_TRY came from c++/java in the eh_region tree, which would
>> allow the RESX expander to emit the proper function for this
>> particular region.  It's not elegant, but it should work.
>
> With your EH rewrite we could make this function explicit in the IL,
> can we?

We can.  Though I was considering recording a flag rather than
the exact decl.  I do not want to encourage ABIs to muck about
with the generic EH representation.


r~

  parent reply	other threads:[~2009-09-08 15:48 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04 13:34 Richard Guenther
2009-09-04 13:37 ` Diego Novillo
2009-09-04 13:41   ` Richard Guenther
2009-09-05 16:37 ` Richard Henderson
2009-09-05 16:38 ` Richard Henderson
2009-09-05 17:24   ` Richard Guenther
2009-09-05 18:11     ` Richard Henderson
2009-09-08 12:37       ` Richard Guenther
2009-09-08 15:20         ` Richard Guenther
2009-09-08 15:49           ` Richard Henderson
2009-09-10 13:12             ` Richard Guenther
2009-09-10 14:37               ` Richard Guenther
2009-09-10 14:52                 ` Richard Guenther
2009-09-10 15:50                   ` Richard Henderson
2009-09-10 16:02                     ` Richard Guenther
2009-09-10 16:06                       ` Richard Guenther
2009-09-10 16:23                         ` Richard Henderson
2009-09-11 13:25                           ` Richard Guenther
2009-09-11 15:41                             ` Richard Henderson
2009-09-11 16:41                               ` Richard Guenther
2009-09-11 17:05                                 ` Richard Henderson
2009-09-13 22:57                                 ` H.J. Lu
2010-12-29  5:30                                   ` H.J. Lu
2010-12-29  5:36                                     ` H.J. Lu
2011-02-08  2:06                                       ` H.J. Lu
2009-09-10 16:12                       ` Richard Henderson
2009-09-10 15:50                   ` Richard Guenther
2009-09-10 15:57                     ` Richard Henderson
2009-09-08 17:38           ` Eric Botcazou
2009-09-08 15:48         ` Richard Henderson [this message]
2009-09-08 16:04           ` Richard Guenther
2009-09-09  9:34             ` Richard Guenther
2009-09-09 15:24               ` Richard Henderson
2009-09-09 15:26                 ` Richard Guenther
2009-09-14  2:43 David Edelsohn
2009-09-14  5:38 ` Gerald Pfeifer
2009-09-14  9:37 ` Richard Guenther
2009-09-15  8:15   ` Gerald Pfeifer
2009-09-15 11:48     ` David Edelsohn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA67CD1.8020602@redhat.com \
    --to=rth@redhat.com \
    --cc=dnovillo@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).