From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18211 invoked by alias); 15 Sep 2009 14:09:09 -0000 Received: (qmail 18181 invoked by uid 22791); 15 Sep 2009 14:09:07 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from iramx2.ira.uni-karlsruhe.de (HELO iramx2.ira.uni-karlsruhe.de) (141.3.10.81) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Sep 2009 14:09:03 +0000 Received: from irams1.ira.uni-karlsruhe.de ([141.3.10.5]) by iramx2.ira.uni-karlsruhe.de with esmtps port 25 id 1MnYiG-0005Aa-IZ; Tue, 15 Sep 2009 16:09:01 +0200 Received: from i10pc67.ilkd.uni-karlsruhe.de ([141.3.24.67]) by irams1.ira.uni-karlsruhe.de with esmtps port 465 id 1MnYiG-0000hJ-DF; Tue, 15 Sep 2009 16:08:56 +0200 Message-ID: <4AAF9FF8.5040905@ira.uka.de> Date: Tue, 15 Sep 2009 14:09:00 -0000 From: Johannes Singler User-Agent: Thunderbird 2.0.0.22 (X11/20090605) MIME-Version: 1.0 To: Benjamin Kosnik CC: libstdc++ , gcc-patches@gcc.gnu.org Subject: Re: [PATCH][libstdc++-v3 parallel mode] Uglification of internal identifiers References: <4AA8CBEA.4050906@ira.uka.de> <20090910111915.34cc2d01@mcgee.artheist.org> <4AADF6E0.1090403@ira.uka.de> <20090914115822.62063e15@mcgee.artheist.org> In-Reply-To: <20090914115822.62063e15@mcgee.artheist.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ATIS-AV: ClamAV (irams1.ira.uni-karlsruhe.de) X-ATIS-AV: ClamAV (iramx2.ira.uni-karlsruhe.de) X-ATIS-AV: Kaspersky (iramx2.ira.uni-karlsruhe.de) X-ATIS-Timestamp: iramx2.ira.uni-karlsruhe.de 1253023741.349525000 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-09/txt/msg00997.txt.bz2 Benjamin Kosnik wrote: >>> Change begin* to __begin*. >> Where? > > As data in the (otherwise abbreviated) ChangeLog entry. Just list the > transformations into something like this. > > Ie: > > 2009-09-10 Johannes Singler > > * include/parallel/*: Uglify internal identifiers as follows. > Change begin* to __begin*. Change x to y. Change z to b. > > etc. > > Maybe this is too much information, anyway, and you can get away with: > > 2009-09-10 Johannes Singler > > * include/parallel/*: Uglify internal identifiers. > > Much less work. Don't care myself. Unless you hear objections just go > with the latter. > >>> Also, as a side note, for this code: >>> >>> + template>> _Iterator3, >>> + typename _IteratorCategory> >>> + class _IteratorTriple >>> { >>> private: >>> - typedef iterator_triple>> - IteratorCategory> type; >>> + typedef _IteratorTriple<_Iterator1, _Iterator2, _Iterator3, >>> + _IteratorCategory> _Self; >>> >>> _Self is redundant with just _IteratorTriple. Is this just a style >>> thing? >> You are right, _Self is redundant. But I would like to fix that >> later. > > Sure. This is what I meant with "stages" above: just start on the > cleanups and do a couple of passes. You don't have to get it 100% the > first time. Okay, so if nobody objects, I will commit the patch I have so far (respecting recent other changes), then do some left-over detail renamings, then convert the tabs to spaces and take case of the line breaks. -- Johannes