public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Johannes Singler <singler@ira.uka.de>
To: Paolo Carlini <paolo.carlini@oracle.com>
Cc: Benjamin Kosnik <bkoz@redhat.com>,
	libstdc++ <libstdc++@gcc.gnu.org>,
	  gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][libstdc++-v3 parallel mode] Uglification of internal     identifiers
Date: Wed, 23 Sep 2009 08:17:00 -0000	[thread overview]
Message-ID: <4AB9D7E7.5050900@ira.uka.de> (raw)
In-Reply-To: <4AB79982.1030506@oracle.com>

Paolo Carlini wrote:
> Hi,
>> Okay, so if nobody objects, I will commit the patch I have so far
>> (respecting recent other changes), then do some left-over detail
>> renamings, then convert the tabs to spaces and take case of the line breaks.
>>   
> first, thanks for this work. I don't know exactly which is the current
> status, just noticed that some names are still not uglified, is that
> being worked on? 

Yes.

> For example, BinaryFunction1, BinaryFunction2,
> traits_type1, traits_type2,
> traitsi_type, value_type1, value_type2, iteratorf_category,
> iterator1_traits, iterator2_traits, unary_op...

I have done another review, and uglified leftover identifiers, including
the above.  If you find some more, please tell me.

> parallel_unbalanced, sequential_tag, 
> count_minimal_n, default_parallel_tag, balanced_quicksort_tag,
> max_element_minimal_n, 

I would consider them part of the "interface".  Since they are likely to
be already used in user programs I would like to not change them.  They
are also unlikely to collide, because the names are very specific.

-- Johannes

  reply	other threads:[~2009-09-23  8:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10  9:54 Johannes Singler
2009-09-10 18:19 ` Benjamin Kosnik
2009-09-14  7:55   ` Johannes Singler
2009-09-14 18:58     ` Benjamin Kosnik
2009-09-15 14:09       ` Johannes Singler
2009-09-15 16:11         ` Benjamin Kosnik
2009-09-21 15:23         ` Paolo Carlini
2009-09-23  8:17           ` Johannes Singler [this message]
2009-09-23  8:52             ` Paolo Carlini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB9D7E7.5050900@ira.uka.de \
    --to=singler@ira.uka.de \
    --cc=bkoz@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=paolo.carlini@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).