From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22573 invoked by alias); 23 Sep 2009 08:10:33 -0000 Received: (qmail 22558 invoked by uid 22791); 23 Sep 2009 08:10:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from iramx2.ira.uni-karlsruhe.de (HELO iramx2.ira.uni-karlsruhe.de) (141.3.10.81) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Sep 2009 08:10:28 +0000 Received: from irams1.ira.uni-karlsruhe.de ([141.3.10.5]) by iramx2.ira.uni-karlsruhe.de with esmtps port 25 id 1MqMvY-0004HN-DI; Wed, 23 Sep 2009 10:10:21 +0200 Received: from i10pc67.ilkd.uni-karlsruhe.de ([141.3.24.67]) by irams1.ira.uni-karlsruhe.de with esmtps port 465 id 1MqMvY-00053Y-7j; Wed, 23 Sep 2009 10:10:16 +0200 Message-ID: <4AB9D7E7.5050900@ira.uka.de> Date: Wed, 23 Sep 2009 08:17:00 -0000 From: Johannes Singler User-Agent: Thunderbird 2.0.0.22 (X11/20090605) MIME-Version: 1.0 To: Paolo Carlini CC: Benjamin Kosnik , libstdc++ , gcc-patches@gcc.gnu.org Subject: Re: [PATCH][libstdc++-v3 parallel mode] Uglification of internal identifiers References: <4AA8CBEA.4050906@ira.uka.de> <20090910111915.34cc2d01@mcgee.artheist.org> <4AADF6E0.1090403@ira.uka.de> <20090914115822.62063e15@mcgee.artheist.org> <4AAF9FF8.5040905@ira.uka.de> <4AB79982.1030506@oracle.com> In-Reply-To: <4AB79982.1030506@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ATIS-AV: ClamAV (irams1.ira.uni-karlsruhe.de) X-ATIS-AV: ClamAV (iramx2.ira.uni-karlsruhe.de) X-ATIS-AV: Kaspersky (iramx2.ira.uni-karlsruhe.de) X-ATIS-Timestamp: iramx2.ira.uni-karlsruhe.de 1253693421.228366000 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-09/txt/msg01605.txt.bz2 Paolo Carlini wrote: > Hi, >> Okay, so if nobody objects, I will commit the patch I have so far >> (respecting recent other changes), then do some left-over detail >> renamings, then convert the tabs to spaces and take case of the line breaks. >> > first, thanks for this work. I don't know exactly which is the current > status, just noticed that some names are still not uglified, is that > being worked on? Yes. > For example, BinaryFunction1, BinaryFunction2, > traits_type1, traits_type2, > traitsi_type, value_type1, value_type2, iteratorf_category, > iterator1_traits, iterator2_traits, unary_op... I have done another review, and uglified leftover identifiers, including the above. If you find some more, please tell me. > parallel_unbalanced, sequential_tag, > count_minimal_n, default_parallel_tag, balanced_quicksort_tag, > max_element_minimal_n, I would consider them part of the "interface". Since they are likely to be already used in user programs I would like to not change them. They are also unlikely to collide, because the names are very specific. -- Johannes