From: Matthias Klose <doko@ubuntu.com>
To: Andrew Haley <aph@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Alexandre Oliva <aoliva@redhat.com>,
Nathan Froyd <froydnj@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Paolo Carlini <paolo.carlini@oracle.com>,
GCJ-patches <java-patches@gcc.gnu.org>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [ping] Re: [patch] PR40134, use a linker script on arm-linux to link with -lgcc_s -lgcc
Date: Thu, 24 Sep 2009 10:07:00 -0000 [thread overview]
Message-ID: <4ABB3BE6.4060800@ubuntu.com> (raw)
In-Reply-To: <4ABB30DE.6050502@redhat.com>
On 24.09.2009 10:42, Andrew Haley wrote:
> Matthias Klose wrote:
>> On 22.09.2009 17:56, Andrew Haley wrote:
>>> Matthias Klose wrote:
>>>> On 11.09.2009 19:12, Matthias Klose wrote:
>>>
>>>>> Applied and checked the attach patch on top of your patch, ran the
>>>>> testsuite without regressions (applied the patch for pr40133 from Paolo
>>>>> for the same test run as well).
>>>>>
>>>>> Matthias
>>>>
>>>> updated the patch to only for arm*-*-linux-*eabi; test results at
>>>> http://gcc.gnu.org/ml/gcc-testresults/2009-09/msg02000.html
>>>>
>>>> Ok for the trunk?
>>>
>>> I'm not at all happy that backtraces are failing now on Java, but I
>>> guess your
>>> patch didn't cause that. OK by me.
>>
>> Without this patch, the build of libjava fails on arm*-*-linux-*eabi:
>>
>> /usr/bin/ld: .libs/jv-convert: hidden symbol `__sync_synchronize' in
>> /root/gcc/newgccsnapshot/gcc-snapshot-20090919/build/./gcc/libgcc.a(linux-atomic.o)
>> is referenced by DSO
>> /usr/bin/ld: final link failed: Nonrepresentable section on output
>> collect2: ld returned 1 exit status
>> make[5]: *** [jv-convert] Error 1
>>
>> Full buildlog at http://people.debian.org/~doko/tmp/snapshot.log.bz2
>>
>> The reason for this is not linking the shared libgcj with -lgcc.
>
> I find this extremely surprising. LDFLAGS are explicitly set to do
> that when building libgcc. I did this myself, and I'm pretty sure that
> it works.
>
> svn diff -r150701:150702
The setting of LDFLAGS to "-Wl,-lgcc" (working around libtool assumptions) in
the Makefile gets overwritten to the empty value when called by the toplevel
make, so this has no effect. The intent to do this with a linker script was to
have it done for every usage.
>> Am I allowed to check in this patch to fix the build failure, or do I
>> have to wait for an approval of an ARM maintainer?
>
> I think you need an ARM maintainer, but I first want to know why your
> build isn't linking with libgcc.
Ok, Richard is seems to be in vacation until early October.
Matthias
next prev parent reply other threads:[~2009-09-24 9:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 9:10 Matthias Klose
2009-07-07 9:56 ` Jakub Jelinek
2009-07-07 11:51 ` Dave Korn
2009-07-07 12:21 ` Jakub Jelinek
2009-07-07 13:45 ` Dave Korn
2009-07-07 13:52 ` H.J. Lu
2009-07-07 15:30 ` Dave Korn
2009-07-07 15:53 ` H.J. Lu
2009-07-07 13:22 ` Nathan Froyd
2009-07-10 7:01 ` Matthias Klose
2009-07-10 7:56 ` Jakub Jelinek
2009-07-13 13:43 ` Matthias Klose
2009-09-09 11:24 ` Jakub Jelinek
2009-09-09 12:27 ` Joseph S. Myers
2009-09-09 13:25 ` Jakub Jelinek
2009-09-09 19:50 ` Richard Henderson
2009-09-09 20:56 ` Joseph S. Myers
2009-09-11 17:13 ` Matthias Klose
2009-09-22 12:26 ` [ping] " Matthias Klose
2009-09-22 15:57 ` Andrew Haley
2009-09-24 8:26 ` Matthias Klose
2009-09-24 8:49 ` Andrew Haley
2009-09-24 10:07 ` Matthias Klose [this message]
2009-09-24 10:45 ` Andrew Haley
2009-10-14 15:15 ` Richard Earnshaw
[not found] ` <1255527525.4842.29.camel@e200601-lin.cambridge.arm.com>
2009-10-21 14:11 ` Matthias Klose
2009-10-30 0:22 ` [ping2] " Matthias Klose
2009-10-30 0:55 ` Paolo Carlini
2009-11-02 16:02 ` Matthias Klose
2009-11-02 16:33 ` Paolo Carlini
2009-11-12 18:21 ` Matthias Klose
2009-11-12 18:47 ` Paolo Carlini
2009-12-09 10:47 ` Matthias Klose
2009-12-09 10:50 ` Paolo Carlini
2009-12-09 10:58 ` Paolo Carlini
2009-12-11 8:48 ` Matthias Klose
2009-12-11 10:00 ` Paolo Carlini
2009-12-14 1:34 ` Matthias Klose
2009-12-11 10:35 ` Joseph S. Myers
2009-11-16 22:47 ` Ralf Wildenhues
2009-11-16 22:48 ` Paolo Carlini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABB3BE6.4060800@ubuntu.com \
--to=doko@ubuntu.com \
--cc=Richard.Earnshaw@arm.com \
--cc=aoliva@redhat.com \
--cc=aph@redhat.com \
--cc=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=java-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).