From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10888 invoked by alias); 3 Oct 2009 05:54:39 -0000 Received: (qmail 10878 invoked by uid 22791); 3 Oct 2009 05:54:38 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-105-friday.noc.nerim.net (HELO mallaury.nerim.net) (62.4.17.105) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 Oct 2009 05:54:34 +0000 Received: from hector.lesours (ours.starynkevitch.net [213.41.244.95]) by mallaury.nerim.net (Postfix) with ESMTP id D1DC4A1057; Sat, 3 Oct 2009 07:54:30 +0200 (CEST) Received: from glinka.lesours ([192.168.0.1]) by hector.lesours with esmtp (Exim 4.69) (envelope-from ) id 1MtxZq-0003ad-BL; Sat, 03 Oct 2009 07:54:42 +0200 Message-ID: <4AC6E736.4010305@starynkevitch.net> Date: Sat, 03 Oct 2009 05:54:00 -0000 From: Basile STARYNKEVITCH User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Gerald Pfeifer CC: gcc-patches , Rafael Espindola , Diego Novillo Subject: Re: gengtype & plugins [#define emitted in wrong order] References: <4AC3CBF5.9030008@starynkevitch.net> <4AC44702.7050508@starynkevitch.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg00184.txt.bz2 Gerald Pfeifer wrote: > On Thu, 1 Oct 2009, Basile STARYNKEVITCH wrote: >> I am also attaching the gcc/ChangeLog entry > > 2009-10-01 Basile Starynkevitch > > * gengtype.c (write_types): Moved call to write_func_for_structure > into seperate loops to ensure that all the functions are emitted > after their declarations and #define-d macros. > > The ChangeLog should only describe what changes, not whay. The latter > you may want to put as comments in the code. Thanks for the comment. Hence, the gcc/ChangeLog should be simply: 2009-10-01 Basile Starynkevitch * gengtype.c (write_types): Moved call to write_func_for_structure into seperate loops. With this change in the changelog, is the patch OK for trunk?? Regards. -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basilestarynkevitchnet mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mines, sont seulement les miennes} ***