Re: PING [PATCH, AVR ] Fix PR19154 Bit Test patch

[Andy H <hutchinsonandy@aim.com>]

Anatoly,

could you  post your  approval of this patch

Andy


Andy H wrote:
> The attached patch creates a full set of patterns to match common bit 
> test and jump for AVR target.
>
> These are typically creted by expressions such as
>
> if (x & 0x4000) ...
>
> The expanded can be  picked up by combine pass and turned into single 
> sbxx instructions.
> The existing patterns failed to match due to limited coverage of modes 
> producing sub-optimal code.
>
> Zero extract patterns are provide for all modes up to DI. Similar AND 
> patterns are provided upto SI mode
> The latter are used by older peephole patterns and historically 
> matched to some RTL for bit test.
>
> Tested with no regressions on todays HEAD  rev 152226
>
> Ok to comit to 4.5 HEAD?
>
>
> Target is avr-unknown-none
> Host   is i686-pc-linux-gnu
>
>        === gcc Summary ===
>
> # of expected passes        49145
> # of unexpected failures    167
> # of unexpected successes    12
> # of expected failures        99
> # of unresolved testcases    39
> # of untested testcases        8
> # of unsupported tests        1806
>
> (SAME BEFORE AFTER PATCH)
>
> 2009-09-27  Andy Hutchinson <hutchinsonandy@gcc.gnu.org>
>
>    PR mid/19154
>    * avr.md (QIDI): Add new mode iterator.
>    (sbrx_branch<mode>): Create new zero extract bit, test and jump
>    patterns for all QI thru DI modes combinations.
>    (sbrx_and_branch<mode>): Create new and based bit test and jump
>    patterns for QI thru SI modes.
>