public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Eric Botcazou <ebotcazou@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: [Patch] Fix bogus 'function does return' warning
Date: Sat, 17 Oct 2009 17:00:00 -0000	[thread overview]
Message-ID: <4AD9F61B.6090907@redhat.com> (raw)
In-Reply-To: <84fc9c000910170446t22378297obefb6e7972549d43@mail.gmail.com>

On 10/17/2009 04:46 AM, Richard Guenther wrote:
> As EH lowering complicates matters in your case (otherwise cfgcleanup
> would fixup all issues) I think a proper place to address this is EH lowering
> (thus I cced rth).

What would you suggest that EH lowering do?  I suppose we could always 
copy the eh path for finally.  It would eliminate the problematic case here.

Really, I'd have preferred this be cleaned up in the 
remove_useless_stmts pass, which Matz recently removed.  But given a 
choice between complicating pass_lower_cf and pass_lower_eh, frankly I'd 
prefer pass_lower_cf -- eh lowering is already complicated enough.


r~

  reply	other threads:[~2009-10-17 16:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 19:51 Eric Botcazou
2009-10-16  9:50 ` Richard Guenther
2009-10-16  9:55   ` Eric Botcazou
2009-10-16 10:38     ` Richard Guenther
2009-10-16 11:12       ` Eric Botcazou
2009-10-16 11:32         ` Richard Guenther
2009-10-16 13:21           ` Eric Botcazou
2009-10-17 10:26             ` Eric Botcazou
2009-10-17 11:29               ` Richard Guenther
2009-10-17 11:36                 ` Eric Botcazou
2009-10-17 14:12                   ` Richard Guenther
2009-10-17 17:00                     ` Richard Henderson [this message]
2009-10-17 17:10                       ` Richard Guenther
2009-10-18 15:49                         ` Eric Botcazou
2009-10-18 16:36                           ` Richard Henderson
2009-10-18 18:41                             ` Eric Botcazou
2009-10-19 15:39                               ` Richard Henderson
2009-10-19 17:32                                 ` Eric Botcazou
2009-10-19 18:30                                   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD9F61B.6090907@redhat.com \
    --to=rth@redhat.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).