From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27245 invoked by alias); 17 Oct 2009 16:52:13 -0000 Received: (qmail 27230 invoked by uid 22791); 17 Oct 2009 16:52:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Oct 2009 16:52:08 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9HGpi8k025203; Sat, 17 Oct 2009 12:51:44 -0400 Received: from stone.twiddle.home (vpn-226-9.phx2.redhat.com [10.3.226.9]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9HGpiTx031887; Sat, 17 Oct 2009 12:51:44 -0400 Message-ID: <4AD9F61B.6090907@redhat.com> Date: Sat, 17 Oct 2009 17:00:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Richard Guenther CC: Eric Botcazou , gcc-patches@gcc.gnu.org Subject: Re: [Patch] Fix bogus 'function does return' warning References: <200910152148.53899.ebotcazou@adacore.com> <200910171043.52316.ebotcazou@adacore.com> <84fc9c000910170424v337a39d6x766bdeb22830ba78@mail.gmail.com> <200910171334.05762.ebotcazou@adacore.com> <84fc9c000910170446t22378297obefb6e7972549d43@mail.gmail.com> In-Reply-To: <84fc9c000910170446t22378297obefb6e7972549d43@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg01141.txt.bz2 On 10/17/2009 04:46 AM, Richard Guenther wrote: > As EH lowering complicates matters in your case (otherwise cfgcleanup > would fixup all issues) I think a proper place to address this is EH lowering > (thus I cced rth). What would you suggest that EH lowering do? I suppose we could always copy the eh path for finally. It would eliminate the problematic case here. Really, I'd have preferred this be cleaned up in the remove_useless_stmts pass, which Matz recently removed. But given a choice between complicating pass_lower_cf and pass_lower_eh, frankly I'd prefer pass_lower_cf -- eh lowering is already complicated enough. r~