From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23967 invoked by alias); 20 Oct 2009 18:14:36 -0000 Received: (qmail 23953 invoked by uid 22791); 20 Oct 2009 18:14:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp20.orange.fr (HELO smtp20.orange.fr) (80.12.242.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Oct 2009 18:14:30 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf2026.orange.fr (SMTP Server) with ESMTP id 43134200004E; Tue, 20 Oct 2009 20:14:28 +0200 (CEST) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf2026.orange.fr (SMTP Server) with ESMTP id 29F3C200005B; Tue, 20 Oct 2009 20:14:28 +0200 (CEST) Received: from [192.168.0.100] (AVelizy-154-1-56-169.w83-199.abo.wanadoo.fr [83.199.38.169]) by mwinf2026.orange.fr (SMTP Server) with ESMTP id E5525200004E; Tue, 20 Oct 2009 20:14:24 +0200 (CEST) Message-ID: <4ADDFE10.9080406@adacore.com> Date: Tue, 20 Oct 2009 18:27:00 -0000 From: Pascal Obry Reply-To: obry@adacore.com User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; fr-FR; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Dave Korn CC: gcc-patches Subject: Re: [PATCH] Add missing parens References: <4ADB6743.4090105@adacore.com> <4ADDF53A.9070500@adacore.com> <4ADDF97A.4080209@gmail.com> In-Reply-To: <4ADDF97A.4080209@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg01316.txt.bz2 Dave, > I can't approve it so I'll just observe that this patch is blatantly > obviously correct and the right thing to do even if there wasn't a bug. There was a bug! The dwarf2 unwinding on x86-64 Windows was broken by this. -- Pascal Obry -- gpg --keyserver keys.gnupg.net --recv-key F949BD3B