From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12850 invoked by alias); 2 Nov 2009 13:31:04 -0000 Received: (qmail 12842 invoked by uid 22791); 2 Nov 2009 13:31:03 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Nov 2009 13:30:56 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA2DUtoL002492 for ; Mon, 2 Nov 2009 08:30:55 -0500 Received: from [IPv6:::1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA2DUs5f021344; Mon, 2 Nov 2009 08:30:54 -0500 Message-ID: <4AEEDF0E.4090101@redhat.com> Date: Mon, 02 Nov 2009 13:31:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5pre) Gecko/20091031 Shredder/3.0pre MIME-Version: 1.0 To: Jakub Jelinek CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Ensure visibility attribute on namespace can't be popped using #pragma GCC visibility pop and vice versa (PR c++/41774) References: <20091021120008.GH14664@tyan-ft48-01.lab.bos.redhat.com> In-Reply-To: <20091021120008.GH14664@tyan-ft48-01.lab.bos.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-11/txt/msg00054.txt.bz2 On 10/21/2009 08:00 AM, Jakub Jelinek wrote: > /* Push the visibility indicated by STR onto the top of the #pragma > visibility stack. */ > > void > -push_visibility (const char *str) > +push_visibility (const char *str, int kind) This needs documentation about the new parameter. OK with that change. Jason