From: Nick Clifton <nickc@redhat.com>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: RFA: Provide a default definition of CONSTANT_ADDRESS_P
Date: Wed, 04 Nov 2009 11:10:00 -0000 [thread overview]
Message-ID: <4AF16126.4060201@redhat.com> (raw)
In-Reply-To: <200910201522.n9KFMaKt029993@ignucius.se.axis.com>
Hi Hans-Peter,
> Wait, shouldn't that be
> #define CONSTANT_ADDRESS_P(X) \
> (CONSTANT_P (X) && LEGITIMATE_CONSTANT_P (X) && GET_CODE (X) != CONST_DOUBLE)
> ? Beware, you're going to have to actually test that.
Yes it probably should. I didn't to risk breaking things though, so I
just the "default" definition of CONSTANT_P and added the check for
CONST_DOUBLES. At some point, in my copious free time, I will have a go
at adding the LEGITIMATE_CONSTANT_P and see if that breaks (or fixes)
anything.
Cheers
Nick
next prev parent reply other threads:[~2009-11-04 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 9:01 Nick Clifton
2009-10-20 9:38 ` Hans-Peter Nilsson
2009-10-20 15:23 ` Hans-Peter Nilsson
2009-11-04 11:10 ` Nick Clifton [this message]
2009-10-22 8:46 ` Hariharan Sandanagobalane
2009-11-03 23:10 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF16126.4060201@redhat.com \
--to=nickc@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).