* [PATCH,AVR]Add ASM_OUTPUT_EXTERNAL to support hidden attribute
@ 2009-11-24 2:24 Andrew Hutchinson
2009-11-28 11:27 ` Anatoly Sokolov
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Hutchinson @ 2009-11-24 2:24 UTC (permalink / raw)
To: gcc-patches, Anatoly Sokolov; +Cc: Weddington, Eric
[-- Attachment #1: Type: text/plain, Size: 383 bytes --]
As hghlighted by failure of visibility tests and noted on PR37202, AVR
needs elf macro to create correct external symbol.
This can be found in config/elfos.h)(
The patch was tested on full c testsuite with no regressions. All
visibility tests now pass.
2009-11-23 Andy Hutchinson <hutchinsonandy@gcc.gnu.org>
* config/avr/avr.h (ASM_OUTPUT_EXTERNAL): Add.
OK FOR 4.5 ?
[-- Attachment #2: visibility.patch --]
[-- Type: text/plain, Size: 701 bytes --]
Index: avr/avr.h
===================================================================
--- avr/avr.h (revision 154478)
+++ avr/avr.h (working copy)
@@ -703,6 +703,15 @@
fprintf (STREAM, "\t.p2align\t%d\n", POWER); \
} while (0)
+/* A C statement (sans semicolon) to output to the stdio stream STREAM
+ any text necessary for declaring the name of an external symbol
+ named NAME which is referenced in this compilation but not defined.
+ It is needed to properly support non-default visibility. */
+
+#define ASM_OUTPUT_EXTERNAL(FILE, DECL, NAME) \
+ default_elf_asm_output_external (FILE, DECL, NAME)
+
+
#define CASE_VECTOR_MODE HImode
#undef WORD_REGISTER_OPERATIONS
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH,AVR]Add ASM_OUTPUT_EXTERNAL to support hidden attribute
2009-11-24 2:24 [PATCH,AVR]Add ASM_OUTPUT_EXTERNAL to support hidden attribute Andrew Hutchinson
@ 2009-11-28 11:27 ` Anatoly Sokolov
2009-11-28 13:48 ` Andrew Hutchinson
0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Sokolov @ 2009-11-28 11:27 UTC (permalink / raw)
To: Andrew Hutchinson, gcc-patches; +Cc: Weddington, Eric
Hi Andy.
>
> 2009-11-23 Andy Hutchinson <hutchinsonandy@gcc.gnu.org>
>
> * config/avr/avr.h (ASM_OUTPUT_EXTERNAL): Add.
>
>
> OK FOR 4.5 ?
Remove comment from patch. Ok.
Anatoly.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH,AVR]Add ASM_OUTPUT_EXTERNAL to support hidden attribute
2009-11-28 11:27 ` Anatoly Sokolov
@ 2009-11-28 13:48 ` Andrew Hutchinson
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Hutchinson @ 2009-11-28 13:48 UTC (permalink / raw)
To: Anatoly Sokolov; +Cc: gcc-patches, Weddington, Eric
Committed.
Anatoly Sokolov wrote:
> Hi Andy.
>
>>
>> 2009-11-23 Andy Hutchinson <hutchinsonandy@gcc.gnu.org>
>>
>> * config/avr/avr.h (ASM_OUTPUT_EXTERNAL): Add.
>>
>>
>> OK FOR 4.5 ?
>
>
> Remove comment from patch. Ok.
>
> Anatoly.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-28 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-24 2:24 [PATCH,AVR]Add ASM_OUTPUT_EXTERNAL to support hidden attribute Andrew Hutchinson
2009-11-28 11:27 ` Anatoly Sokolov
2009-11-28 13:48 ` Andrew Hutchinson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).