[PATCH] Document build prereqs for cygwin [was Re: GCC 4.5 is uncompilable]

[PATCH] Document build prereqs for cygwin [was Re: GCC 4.5 is uncompilable]

[Dave Korn]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

Richard Guenther wrote:
> On Fri, Nov 20, 2009 at 9:06 PM, Dave Korn wrote:
>> Piotr Wyderski wrote:
>>> Kai Tietz wrote:
>>>
>>>> This error you get is more related to used binutils version.The
>>>> warning you get looks more like a cripled '-Wl,--tsaware'.
>>> Thanks, that looks like a good explanation.
>>  Yes, I added this to HEAD recently
>>
>>>> Which binutils version you are using?
>>> $ ld -v
>>> GNU ld (GNU Binutils) 2.18.50.20080625
>>>
>>> I'll try to upgrade binutils and then repeat the build process.
>>  If that doesn't fix it please let me know.  BTW I'm currently bootstrapping
>> r.154370 and it's got as far as building the target libraries post stage 3
>> without any sign of this problem, so you should be ok.
> 
> You should add the minimal required binutils version for cycwin to the
> install section of the manual.
> 
> Richard.

  Indeed we should.

gcc/ChangeLog:

	* doc/install.texi (Specific#x-x-cygwin): Document minimum required
	binutils version, and rework target configuration description.

  Tested by "make doc info html dvi pdf" on i686-pc-cygwin and eyeballing the
generated html pdf and info files.  OK for head?

    cheers,
      DaveK

[-- Attachment #2: cygwin-install-requirements.diff --]
[-- Type: text/x-c, Size: 950 bytes --]

Index: gcc/doc/install.texi
===================================================================
--- gcc/doc/install.texi	(revision 154664)
+++ gcc/doc/install.texi	(working copy)
@@ -4448,7 +4448,13 @@ Ports of GCC are included with the
 GCC will build under Cygwin without modification; it does not build
 with Microsoft's C++ compiler and there are no plans to make it do so.
 
-Cygwin can be compiled with i?86-pc-cygwin.
+The Cygwin-targeted compiler can be configured with i?86-pc-cygwin,
+according to the default x86 cpu architecture desired.  (The configured-in
+choice can be overridden on the command-line by using the @option{-march=}
+and @option{-mtune=} options).  It requires a fairly modern version of
+binutils in support, as it takes advantage of many recent enhancements and
+bugfixes; use either the latest official GNU binutils release in the Cygwin
+distribution, or version 2.20 or above if building your own.
 
 @html
 <hr />

Re: [PATCH] Document build prereqs for cygwin [was Re: GCC 4.5 is uncompilable]

[Dave Korn]

Dave Korn wrote:

> 	* doc/install.texi (Specific#x-x-cygwin): Document minimum required
> 	binutils version, and rework target configuration description.

>   OK for head?

  In fact, it occurs to me I have an outstanding OK to backport(*) a patch
that requires this to the 4.4 branch, so I should ask for OK for this doc
patch for 4.4 branch as well.

  OK for head and 4.4?

    cheers,
      DaveK
-- 
(*) - http://gcc.gnu.org/ml/gcc-patches/2009-10/msg01681.html

Re: [PATCH] Document build prereqs for cygwin [was Re: GCC 4.5 is uncompilable]

[Dave Korn]

Dave Korn wrote:
> Dave Korn wrote:
> 
>> 	* doc/install.texi (Specific#x-x-cygwin): Document minimum required
>> 	binutils version, and rework target configuration description.
> 
>>   OK for head?
> 
>   In fact, it occurs to me I have an outstanding OK to backport(*) a patch
> that requires this to the 4.4 branch, so I should ask for OK for this doc
> patch for 4.4 branch as well.
> 
>   OK for head and 4.4?

  Ping?

    cheers,
      DaveK

Re: [PATCH] Document build prereqs for cygwin [was Re: GCC 4.5 is uncompilable]

[Gerald Pfeifer]

On Sun, 20 Dec 2009, Dave Korn wrote:
>>> 	* doc/install.texi (Specific#x-x-cygwin): Document minimum required
>>> 	binutils version, and rework target configuration description.

-Cygwin can be compiled with i?86-pc-cygwin.
+The Cygwin-targeted compiler can be configured with i?86-pc-cygwin,
+according to the default x86 cpu architecture desired.  (The configured-in
+choice can be overridden on the command-line by using the @option{-march=}
+and @option{-mtune=} options).  It requires a fairly modern version of
+binutils in support, as it takes advantage of many recent enhancements and
+bugfixes; use either the latest official GNU binutils release in the Cygwin
+distribution, or version 2.20 or above if building your own.

>>   OK for head and 4.4?
>   Ping?

I was waiting for a Cygwin maintainer to review this patch and suggest
copying them explicitly in case.

As for the patch, I would not say "configured with i?86-pc-cygwin" since
that will likely lead non-expert users to specify this verbatim which, at
least from what I'd expect, won't work?

I also would not document -march=/-mtune= here, since this is not specific
to Cygwin at all.

And I would not refer to "fairly modern" since that is always relative.
Just keep the part after the semicolon.

The patch is fine with these changes, let's give the Cygwin maintainers
a few days to respond, though, in case they disagree.

Gerald

Re: [PATCH] Document build prereqs for cygwin [was Re: GCC 4.5 is uncompilable]

[Gerald Pfeifer]

[ Umpf, Christopher's address in MAINTAINERS actually is not correct;
  let's try me.gcc@cgf.cx instead of me.gcc@gcc.gnu.org ]

On Sun, 20 Dec 2009, Dave Korn wrote:
>>> 	* doc/install.texi (Specific#x-x-cygwin): Document minimum required
>>> 	binutils version, and rework target configuration description.

-Cygwin can be compiled with i?86-pc-cygwin.
+The Cygwin-targeted compiler can be configured with i?86-pc-cygwin,
+according to the default x86 cpu architecture desired.  (The configured-in
+choice can be overridden on the command-line by using the @option{-march=}
+and @option{-mtune=} options).  It requires a fairly modern version of
+binutils in support, as it takes advantage of many recent enhancements and
+bugfixes; use either the latest official GNU binutils release in the Cygwin
+distribution, or version 2.20 or above if building your own.

>>   OK for head and 4.4?
>   Ping?

I was waiting for a Cygwin maintainer to review this patch and suggest
copying them explicitly in case.

As for the patch, I would not say "configured with i?86-pc-cygwin" since
that will likely lead non-expert users to specify this verbatim which, at
least from what I'd expect, won't work?

I also would not document -march=/-mtune= here, since this is not specific
to Cygwin at all.

And I would not refer to "fairly modern" since that is always relative.
Just keep the part after the semicolon.

The patch is fine with these changes, let's give the Cygwin maintainers
a few days to respond, though, in case they disagree.

Gerald

Re: [PATCH] Document build prereqs for cygwin [was Re: GCC 4.5 is uncompilable]

[Christopher Faylor]

Please just assume that I read the mailing list.  I've set the reply-to
of this message so that I don't have to see a horde of comments in my
inbox.

On Mon, Dec 28, 2009 at 05:37:40AM +0100, Gerald Pfeifer wrote:
>[ Umpf, Christopher's address in MAINTAINERS actually is not correct;
>  let's try XXX instead of YYY ]

The patch is fine.  I trust whatever Dave thinks is best.

In fact, he probably should be added to the list of gcc-for-cygwin
maintainers since he does infinitely more with gcc for cygwin than I do
these days.

cgf

Re: [PATCH] Document build prereqs for cygwin [was Re: GCC 4.5 is uncompilable]

[Dave Korn]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

Gerald Pfeifer wrote:

> The patch is fine with these changes, let's give the Cygwin maintainers
> a few days to respond, though, in case they disagree.

  Here's what I ended up committing, tested by running "make doc info dvi html
pdf" in an existing build dir with no error and inspecting the html, pdf and
info versions of the docs.

gcc/ChangeLog:

	* doc/install.texi (Specific#x-x-cygwin): Document minimum required
	binutils version, and reword target configuration description.

  I'll leave it a day or two before backporting to 4.4, in case anyone comes
up with any suggestions.

    cheers,
      DaveK


[-- Attachment #2: cygwin-install-info.diff --]
[-- Type: text/x-c, Size: 1229 bytes --]

Index: gcc/doc/install.texi
===================================================================
--- gcc/doc/install.texi	(revision 155820)
+++ gcc/doc/install.texi	(working copy)
@@ -45,7 +45,8 @@
 @end ifset
 
 @c Copyright (C) 1988, 1989, 1992, 1993, 1994, 1995, 1996, 1997, 1998,
-@c 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc.
+@c 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 
+@c 2010 Free Software Foundation, Inc.
 @c *** Converted to texinfo by Dean Wakerley, dean@wakerley.com
 
 @c IMPORTANT: whenever you modify this file, run `install.texi2html' to
@@ -4447,7 +4448,11 @@ Ports of GCC are included with the
 GCC will build under Cygwin without modification; it does not build
 with Microsoft's C++ compiler and there are no plans to make it do so.
 
-Cygwin can be compiled with i?86-pc-cygwin.
+The Cygwin native compiler can be configured to target any 32-bit x86
+cpu architecture desired; the default is i686-pc-cygwin.  It should be
+used with as up-to-date a version of binutils as possible; use either
+the latest official GNU binutils release in the Cygwin distribution,
+or version 2.20 or above if building your own.
 
 @html
 <hr />